29467[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 17
-
Mr. Jenkins commented on patch set 1 04/14/14, 23:05
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16005/ : SUCCESS -
Stefan Neufeind commented on patch set 1 V +1 CR +1 04/15/14, 00:05
PathUtility.php:236$baseFilenameOrPath would need to have one / on the end chopped. We might however skip that since getCanonicalPath() cleans that up anyway (tested) -
Xavier Perseguers commented on patch set 1 04/15/14, 11:09
PathUtilityTest.php:240looks like a wrong indent is used -
Markus Klein commented on patch set 1 04/15/14, 11:12
PathUtilityTest.php:240ReplyDone -
Markus Klein uploaded patch set 2 04/15/14, 11:12
-
Mr. Jenkins commented on patch set 2 04/15/14, 11:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16015/ : SUCCESS -
Stefan Neufeind commented on patch set 2 V +1 CR +1 04/15/14, 12:43
reapplying vote -
Frans Saris commented on patch set 2 CR +1 04/16/14, 11:53
Unit tests are green. Do you have some snippet to verify this other than running the tests? -
Frans Saris commented on patch set 2 V +1 04/16/14, 12:01
tested with https://review.typo3.org/#/c/29468/ -
Wouter Wolters commented on patch set 2 04/16/14, 18:08
The patch where you can test this path with fails for me https://review.typo3.org/#/c/29468/ -
Markus Klein uploaded patch set 3 04/16/14, 22:36
-
Markus Klein commented on patch set 3 04/16/14, 22:38
No changes, just repushed with dependency. Votes still apply. had v+2, r+2 -
Mr. Jenkins commented on patch set 3 04/16/14, 22:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16042/ : SUCCESS -
Wouter Wolters voted on patch set 3 V +1 CR +1 04/22/14, 19:20
-
Markus Klein commented on patch set 3 05/06/14, 10:19
ping! -
Markus Klein commented on patch set 3 V +2 CR +2 05/22/14, 12:09
Enough votes on the depending issue, where people needed this patch to test the other. -
Markus Klein merged patch set 4 05/22/14, 12:09