Review main Merged

29467[BUGFIX] PathUtility::get...FileOrPath() does not work with basepath

Markus Klein CR +2 V +2 Easy +13 −2 updated 05/22/14, 12:09

Commit message

PathUtility::getAbsolutePathOfRelativeReferencedFileOrPath()
Add a check to the function to identify a given basepath as described
in the function header.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Wouter Wolters +1

Issues 1

Files 2

Review log 17

  1. Mr. Jenkins commented on patch set 1 04/14/14, 23:05

  2. Stefan Neufeind commented on patch set 1 V +1 CR +1 04/15/14, 00:05

    PathUtility.php:236

    $baseFilenameOrPath would need to have one / on the end chopped. We might however skip that since getCanonicalPath() cleans that up anyway (tested)
  3. Xavier Perseguers commented on patch set 1 04/15/14, 11:09

    PathUtilityTest.php:240

    looks like a wrong indent is used
  4. Markus Klein commented on patch set 1 04/15/14, 11:12

    PathUtilityTest.php:240 Reply

    Done
  5. Markus Klein uploaded patch set 2 04/15/14, 11:12

  6. Mr. Jenkins commented on patch set 2 04/15/14, 11:25

  7. Stefan Neufeind commented on patch set 2 V +1 CR +1 04/15/14, 12:43

    reapplying vote
  8. Frans Saris commented on patch set 2 CR +1 04/16/14, 11:53

    Unit tests are green. Do you have some snippet to verify this other than running the tests?
  9. Frans Saris commented on patch set 2 V +1 04/16/14, 12:01

  10. Wouter Wolters commented on patch set 2 04/16/14, 18:08

    The patch where you can test this path with fails for me https://review.typo3.org/#/c/29468/
  11. Markus Klein uploaded patch set 3 04/16/14, 22:36

  12. Markus Klein commented on patch set 3 04/16/14, 22:38

    No changes, just repushed with dependency. Votes still apply. had v+2, r+2
  13. Mr. Jenkins commented on patch set 3 04/16/14, 22:51

  14. Wouter Wolters voted on patch set 3 V +1 CR +1 04/22/14, 19:20

  15. Markus Klein commented on patch set 3 05/06/14, 10:19

    ping!
  16. Markus Klein commented on patch set 3 V +2 CR +2 05/22/14, 12:09

    Enough votes on the depending issue, where people needed this patch to test the other.
  17. Markus Klein merged patch set 4 05/22/14, 12:09