Review main Merged

29470[CLEANUP] Remove unused [BE][usePHPFileFunctions] option

Markus Klein CR +2 V +2 Easy +2 −1 updated 04/15/14, 01:09

Commit message

Review

  • Code review CR +2
    • Stefan Neufeind +2
  • Verified V +2
    • Stefan Neufeind +2

Issues 1

Files 2

Review log 6

  1. Stefan Neufeind commented on patch set 1 V +1 CR +1 04/15/14, 00:45

    Looks good. Verified it's not used anymore. Didn't (yet) test the upgradeservice that removes the old value. Only a nitpick (indention).

    SilentConfigurationUpgradeService.php:69

    indention
  2. Markus Klein uploaded patch set 2 04/15/14, 00:54

  3. Stefan Neufeind voted on patch set 2 V +2 CR +2 04/15/14, 00:56

  4. Stefan Neufeind merged patch set 3 04/15/14, 00:56

  5. Mr. Jenkins commented on patch set 1 04/15/14, 00:57

  6. Mr. Jenkins commented on patch set 2 04/15/14, 01:09