29555[TASK] Configurable width of the Element Browser
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Wouter Wolters +1
- Laurent Cherpit +1
-
Verified V +2
- Georg Ringer +2
- Wouter Wolters +1
Issues 1
Files 3
Review log 22
-
Mr. Jenkins commented on patch set 1 04/18/14, 03:38
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16058/ : SUCCESS -
Markus Klein commented on patch set 1 04/18/14, 09:13
FormEngine.js:46no need for () -
Stefan Neufeind commented on patch set 1 04/18/14, 11:28
Shouldn't we then also make the height flexible as well? -
Stefan Neufeind commented on patch set 1 04/18/14, 11:29
Helmut commented: I would add width and height to params (as these are transferred anyway from TCA) and not introduce a new argument to the function which is not used -
Georg Ringer uploaded patch set 2 04/18/14, 14:09
-
Mr. Jenkins commented on patch set 2 04/18/14, 14:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16062/ : SUCCESS -
Helmut Hummel commented on patch set 2 CR +1 04/18/14, 14:39
Nice! -
Frans Saris commented on patch set 2 CR -1 04/18/14, 15:05
InlineElement.php:907Please decleare $width and $height to prevent warningsFormEngine.php:2604Same hereFormEngine.php:3921Same here -
Stefan Neufeind uploaded patch set 3 04/18/14, 22:38
-
Stefan Neufeind voted on patch set 3 CR +1 04/18/14, 22:38
-
Mr. Jenkins commented on patch set 3 04/18/14, 22:51
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16070/ : SUCCESS -
Laurent Cherpit commented on patch set 3 04/20/14, 11:28
FormEngine.js:47missing space before character "colon" -
Wouter Wolters uploaded patch set 4 04/22/14, 20:37
-
Laurent Cherpit voted on patch set 4 CR +1 04/22/14, 20:47
-
Wouter Wolters commented on patch set 4 V +1 CR +1 04/22/14, 20:47
Tested with adding for example config to pages:content_from_pid 'appearance' => array( 'elementBrowserWidth' => 400, 'elementBrowserHeight' => 832, ), -
Mr. Jenkins commented on patch set 4 04/22/14, 20:50
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16091/ : SUCCESS -
Georg Ringer voted on patch set 4 V +2 CR +2 04/23/14, 02:56
-
Georg Ringer merged patch set 5 04/23/14, 02:56
-
Christian Kuhn commented on patch set 5 04/23/14, 06:56
Nice patch, this obsoletes a core patch I'm moving around since 4.3. But hey, this patch must be signed-off by Ernesto. Fine if that happened internally, but it would be better to have this explicitly stated. Furthermore, this issue must have documentation. Please take care of that, and maybe even trigger Francois that this late feature (!) made it, so 6.2 documentation can be adapted? -
Wouter Wolters commented on patch set 5 04/23/14, 06:57
Needs a documentation issue. Missend that yesterday evening. -
Markus Klein commented on patch set 5 04/23/14, 09:06
I tend to revert this immediately: - missing documentation - not enough votes - no statement of Ernesto -
Jigal van Hemert commented on patch set 5 04/23/14, 10:35
Reverted This patchset was reverted in change: Ia1ffee069f825b678748808d756a2c04fd8edb18