Review main Merged

29555[TASK] Configurable width of the Element Browser

Georg Ringer CR +2 V +2 Easy +38 −6 updated 04/23/14, 10:35

Commit message

The width of the element browser is sadly hardcoded to 600 and 650.

In many situations the element browser would need more place and
with this tiny change it would be easily possible to change
that behaviour without overloading the whole file.

Review

  • Code review CR +2
    • Georg Ringer +2
    • Wouter Wolters +1
    • Laurent Cherpit +1
  • Verified V +2
    • Georg Ringer +2
    • Wouter Wolters +1

Issues 1

Files 3

Review log 22

  1. Mr. Jenkins commented on patch set 1 04/18/14, 03:38

  2. Markus Klein commented on patch set 1 04/18/14, 09:13

    FormEngine.js:46

    no need for ()
  3. Stefan Neufeind commented on patch set 1 04/18/14, 11:28

    Shouldn't we then also make the height flexible as well?
  4. Stefan Neufeind commented on patch set 1 04/18/14, 11:29

    Helmut commented: I would add width and height to params (as these are transferred anyway from TCA) and not introduce a new argument to the function which is not used
  5. Georg Ringer uploaded patch set 2 04/18/14, 14:09

  6. Mr. Jenkins commented on patch set 2 04/18/14, 14:23

  7. Helmut Hummel commented on patch set 2 CR +1 04/18/14, 14:39

    Nice!
  8. Frans Saris commented on patch set 2 CR -1 04/18/14, 15:05

    InlineElement.php:907

    Please decleare $width and $height to prevent warnings

    FormEngine.php:2604

    Same here

    FormEngine.php:3921

    Same here
  9. Stefan Neufeind uploaded patch set 3 04/18/14, 22:38

  10. Stefan Neufeind voted on patch set 3 CR +1 04/18/14, 22:38

  11. Mr. Jenkins commented on patch set 3 04/18/14, 22:51

  12. Laurent Cherpit commented on patch set 3 04/20/14, 11:28

    FormEngine.js:47

    missing space before character "colon"
  13. Wouter Wolters uploaded patch set 4 04/22/14, 20:37

  14. Laurent Cherpit voted on patch set 4 CR +1 04/22/14, 20:47

  15. Wouter Wolters commented on patch set 4 V +1 CR +1 04/22/14, 20:47

    Tested with adding for example config to pages:content_from_pid 'appearance' => array( 'elementBrowserWidth' => 400, 'elementBrowserHeight' => 832, ),
  16. Mr. Jenkins commented on patch set 4 04/22/14, 20:50

  17. Georg Ringer voted on patch set 4 V +2 CR +2 04/23/14, 02:56

  18. Georg Ringer merged patch set 5 04/23/14, 02:56

  19. Christian Kuhn commented on patch set 5 04/23/14, 06:56

    Nice patch, this obsoletes a core patch I'm moving around since 4.3. But hey, this patch must be signed-off by Ernesto. Fine if that happened internally, but it would be better to have this explicitly stated. Furthermore, this issue must have documentation. Please take care of that, and maybe even trigger Francois that this late feature (!) made it, so 6.2 documentation can be adapted?
  20. Wouter Wolters commented on patch set 5 04/23/14, 06:57

    Needs a documentation issue. Missend that yesterday evening.
  21. Markus Klein commented on patch set 5 04/23/14, 09:06

    I tend to revert this immediately: - missing documentation - not enough votes - no statement of Ernesto
  22. Jigal van Hemert commented on patch set 5 04/23/14, 10:35

    Reverted This patchset was reverted in change: Ia1ffee069f825b678748808d756a2c04fd8edb18