Review main Merged

29559[FEATURE] Override check/radio labels with TSConfig

Clément MICHELET CR +2 V +2 Normal +65 −5 updated 01/01/15, 19:03

Commit message

Enable locallang override from TSConfig with reference (LLL:) or value.

Use the following instructions :
TCEFORM.[table name].[field].altLabels.[key]

For check fields, [key] is the index of the checkbox.
For radio fields, [key] is the value of the radio button.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Benni Mack +1
  • Verified V +2
    • Wouter Wolters +2
    • Benni Mack +1

Issues 1

Files 3

Review log 41

Show 16 earlier messages
  1. Clément MICHELET commented on patch set 1 04/18/14, 15:31

    Wrong ticket number : #58033 instead of #580333
  2. Mr. Jenkins commented on patch set 1 CR -1 V -1 04/18/14, 15:40

  3. Clément MICHELET uploaded patch set 2 04/18/14, 15:58

  4. Mr. Jenkins commented on patch set 2 04/18/14, 16:11

  5. Christian Kuhn commented on patch set 2 04/19/14, 09:17

    Thanks Clément for your first patch! I hope you had a good time managing the workflow, seems all went fine at first glance. The patch itself is a feature and correctly marked by you as such, so we have little chance to still do that for our stable release 6.2. Since "master" is also not open for new features yet, the patch will have to wait until we branched off 6.2. Because of that, you will probably see not too much review effort at the moment, so please be a bit please be patient in this regard.
  6. Clément MICHELET commented on patch set 2 04/22/14, 08:24

    Hi Christian, Everything was well explained on the wiki article even for a new user on git. So it was pleasant to have everything working fine.
  7. Clément MICHELET uploaded patch set 3 04/23/14, 09:56

  8. Mr. Jenkins commented on patch set 3 04/23/14, 10:09

  9. Wouter Wolters commented on patch set 3 04/23/14, 17:02

    FormEngine.php:1750

    space after ( not needed

    FormEngine.php:1755

    ===
  10. Clément MICHELET uploaded patch set 4 04/24/14, 09:40

  11. Mr. Jenkins commented on patch set 4 04/24/14, 09:53

  12. Anja Leichsenring uploaded patch set 5 12/12/14, 21:05

  13. Anja Leichsenring commented on patch set 5 CR -1 12/12/14, 21:10

    still working on the rebase
  14. Anja Leichsenring uploaded patch set 6 12/12/14, 21:32

  15. Anja Leichsenring uploaded patch set 7 12/12/14, 21:41

  16. Anja Leichsenring uploaded patch set 8 12/12/14, 21:44

  1. Anja Leichsenring updated the commit message in patch set 9 12/12/14, 21:45

  2. Anja Leichsenring voted on patch set 9 CR +1 V +1 12/12/14, 21:46

  3. Mathias Schreiber voted on patch set 9 CR +1 V +1 12/14/14, 09:30

  4. Mathias Schreiber wrote 12/17/14, 14:33

    Topic set to Formengine
  5. Mathias Schreiber uploaded patch set 10 12/18/14, 10:14

  6. Anja Leichsenring commented on patch set 10 CR -1 12/20/14, 21:21

    @Mattes you overrode my latest changes, including the added rst file, with your patchset. Would you mind to repair this? Thanks.
  7. Mathias Schreiber uploaded patch set 11 12/21/14, 10:01

  8. Anja Leichsenring voted on patch set 11 CR +1 V +1 12/21/14, 13:43

  9. Markus Klein commented on patch set 11 CR -1 V -1 12/21/14, 13:49

    CheckboxElement.php:35

    We introduce a backreference to formegine again here. That should be avoided.
  10. Markus Klein commented on patch set 11 12/21/14, 13:49

  11. Anja Leichsenring uploaded patch set 12 12/21/14, 14:55

  12. Anja Leichsenring commented on patch set 12 CR +1 V +1 12/21/14, 14:55

    sorry, overlooked that
  13. Wouter Wolters commented on patch set 12 12/21/14, 15:11

    RadioElement.php:54

    space after if
  14. Alexander Opitz voted on patch set 12 CR -1 12/22/14, 09:27

  15. Alexander Opitz uploaded patch set 13 12/22/14, 09:30

  16. Alexander Opitz commented on patch set 13 V +1 CR +1 12/22/14, 09:30

    Fixed missing space
  17. Markus Klein commented on patch set 13 12/22/14, 12:39

    RadioElement.php:54

    why not using $checkbox?
  18. Mathias Schreiber commented on patch set 13 CR -2 12/29/14, 08:45

    working on it
  19. Mathias Schreiber uploaded patch set 14 12/29/14, 08:47

  20. Mathias Schreiber commented on patch set 14 CR +1 V +1 12/29/14, 08:48

    took Markus' remark into account plus I replaced the $checkbox with $radioButton because after all... we're working on radioButtons here :)
  21. Wouter Wolters voted on patch set 14 CR +1 12/29/14, 17:55

  22. Benni Mack uploaded patch set 15 12/31/14, 12:19

  23. Benni Mack commented on patch set 15 CR +1 V +1 12/31/14, 12:20

    the previous version did not work at all anymore.
  24. Wouter Wolters voted on patch set 15 V +2 CR +2 01/01/15, 19:03

  25. Wouter Wolters merged patch set 15 01/01/15, 19:03