Review main Merged

29581[BUGFIX] Include RSA JS files in HTML header

Helmut Hummel CR +2 V +2 Easy +5 −3 updated 04/22/14, 15:45

Commit message

Due to an oddity in page renderer, we cannot
add the required JavaScript to the footer
as it would not be rendered.

Clean up the JavaScript to correctly work even
when included in the header and change the hook
to add the JS files to the header.

Review

  • Code review CR +2
    • Markus Klein +2
    • Oliver Klee +1
  • Verified V +2
    • Markus Klein +2
    • anonymized-58955 +1

Issues 2

Files 2

Review log 7

  1. Mr. Jenkins commented on patch set 1 04/20/14, 10:45

  2. Markus Klein voted on patch set 1 CR +1 04/20/14, 10:54

  3. Oliver Klee voted on patch set 1 CR +1 04/20/14, 11:32

  4. anonymized-58955 voted on patch set 1 V +1 04/21/14, 07:18

  5. Markus Klein voted on patch set 1 V +1 04/22/14, 15:40

  6. Markus Klein voted on patch set 1 V +2 CR +2 04/22/14, 15:45

  7. Markus Klein merged patch set 2 04/22/14, 15:45