Review main Merged

29582[TASK] Clarify reset in page renderer comment

Helmut Hummel CR +2 V +2 Easy +18 −1 updated 05/06/14, 22:14

Commit message

Also add tests to enforce this behavior.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 2

Review log 11

  1. Mr. Jenkins commented on patch set 1 04/20/14, 11:17

  2. Markus Klein voted on patch set 1 CR +1 04/22/14, 15:43

  3. Markus Klein voted on patch set 1 V +1 04/22/14, 15:47

  4. Wouter Wolters commented on patch set 1 V +1 CR -1 04/22/14, 19:41

    Forge ticket is already marked as resolved..
  5. Markus Klein commented on patch set 1 04/22/14, 19:55

    Reply

    That is valid. This ticket has multiple (valid) fixes. Maybe we can just add another ticket here and set #58010 as related
  6. Wouter Wolters rebased onto patch set 1 05/06/14, 20:29

  7. Wouter Wolters updated the commit message in patch set 2 05/06/14, 20:32

  8. Wouter Wolters commented on patch set 3 V +2 CR +2 05/06/14, 20:33

    Only added a related ticket in Forge to have it separated.
  9. Wouter Wolters merged patch set 4 05/06/14, 20:33

  10. Mr. Jenkins commented on patch set 2 05/06/14, 21:59

  11. Mr. Jenkins commented on patch set 3 05/06/14, 22:14