29605[FEATURE] Add "LLL:" support in PAGE.inlineLanguageLabel
Commit message
Review
-
Code review CR +2
- Frank Nägler +2
- Göran Bodenschatz +1
- Nicole Hummel +1
-
Verified V +2
- Frank Nägler +2
- Nicole Hummel +1
Issues 1
Files 2
Review log 26
Show 1 earlier messages
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 04/22/14, 13:56
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16088/ : FAILURE
-
Clément MICHELET uploaded patch set 2 04/22/14, 14:13
-
Mr. Jenkins commented on patch set 2 04/22/14, 14:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16089/ : SUCCESS -
Wouter Wolters commented on patch set 2 CR -1 04/22/14, 19:46
Hi Clément, thanks for your second patch! Your patch doesn't comply to our Coding Guide Lines. You can read the guidelines over here: http://docs.typo3.org/typo3cms/CodingGuidelinesReference/ We use tabs instead of spaces. Curly braces on the same line as a function or if-statement line. You are also missing a releases line. For now please set it to 6.3 If you have any questions you can always drop me an e-mail! -
Clément MICHELET uploaded patch set 3 04/23/14, 08:35
-
Clément MICHELET uploaded patch set 4 04/23/14, 08:38
-
Mr. Jenkins commented on patch set 3 04/23/14, 08:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16092/ : SUCCESS -
Mr. Jenkins commented on patch set 4 04/23/14, 08:53
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16093/ : SUCCESS -
Wouter Wolters commented on patch set 4 04/23/14, 17:04
PageRenderer.php:1844spaces are used here, make it a tabPageRenderer.php:1848space after if Make it === TRUEPageRenderer.php:1849space after foreachPageRenderer.php:1852spaces are used here make it a tabPageRenderer.php:2820This whole new code makes use of spaces, make it to tabs here -
Clément MICHELET uploaded patch set 5 04/24/14, 11:03
-
Mr. Jenkins commented on patch set 5 04/24/14, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16112/ : SUCCESS -
Dmitry Dulepov commented on patch set 5 CR +1 04/28/14, 08:08
PageRenderer.php:1850Why do you need a function here? Is it only for code completion? :) -
Clément MICHELET commented on patch set 5 05/05/14, 16:06
PageRenderer.php:1850Reply1) Some times ago I've found an article which talks about using methods instead of $GLOBALS in TYPO3 core. I don't remember where. 2) I'm not sure about the safety of using directly $GLOBALS['LANG'] in PageRenderer and if it has some performance issues. In my tests, it seems there is no issues. So, with a method, I'll just have to correct the code inside getLanguageService or elsewhere (initialization, ...) instead of inside of addInlineLanguageLabelArray 3) There are some hooks on PageRenderer with an instance as argument. If an hook need to access LanguageService, it has an accessor and 2) is not a problem at all. But if it's necessary to change to $GLOBALS['LANG'], I can switch to. -
Michael Oehlhof voted on patch set 5 CR +1 01/04/15, 01:02
-
Thomas Deuling voted on patch set 5 CR +1 01/05/15, 11:21
-
Benni Mack updated the commit message in patch set 6 03/01/15, 19:16
-
Benni Mack commented on patch set 6 03/01/15, 19:16
Hey Clement, care to update your patch? -
Michael Oehlhof voted on patch set 6 CR +1 03/01/15, 19:19
-
Clément MICHELET commented on patch set 6 03/02/15, 10:08
Hi Benjamin, I will try to update my patch this week. -
Michael Oehlhof uploaded patch set 7 03/18/15, 21:02
-
Michael Oehlhof commented on patch set 7 CR +1 03/18/15, 21:03
Solved merge conflict. -
Nicole Hummel uploaded patch set 8 03/19/15, 17:53
-
Nicole Hummel voted on patch set 8 CR +1 V +1 03/19/15, 17:53
-
Göran Bodenschatz voted on patch set 8 CR +1 03/19/15, 18:33
-
Frank Nägler voted on patch set 8 V +2 CR +2 04/04/15, 19:41
-
Frank Nägler merged patch set 8 04/04/15, 19:41