Review main Merged

29605[FEATURE] Add "LLL:" support in PAGE.inlineLanguageLabel

Clément MICHELET CR +2 V +2 Easy +18 −2 updated 04/04/15, 19:41

Commit message

You can add either a constant or a locallang reference using
page.inlineLanguageLabel.[key]

Review

  • Code review CR +2
    • Frank Nägler +2
    • Göran Bodenschatz +1
    • Nicole Hummel +1
  • Verified V +2
    • Frank Nägler +2
    • Nicole Hummel +1

Issues 1

Files 2

Review log 26

Show 1 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 04/22/14, 13:56

  1. Clément MICHELET uploaded patch set 2 04/22/14, 14:13

  2. Mr. Jenkins commented on patch set 2 04/22/14, 14:27

  3. Wouter Wolters commented on patch set 2 CR -1 04/22/14, 19:46

    Hi Clément, thanks for your second patch! Your patch doesn't comply to our Coding Guide Lines. You can read the guidelines over here: http://docs.typo3.org/typo3cms/CodingGuidelinesReference/ We use tabs instead of spaces. Curly braces on the same line as a function or if-statement line. You are also missing a releases line. For now please set it to 6.3 If you have any questions you can always drop me an e-mail!
  4. Clément MICHELET uploaded patch set 3 04/23/14, 08:35

  5. Clément MICHELET uploaded patch set 4 04/23/14, 08:38

  6. Mr. Jenkins commented on patch set 3 04/23/14, 08:49

  7. Mr. Jenkins commented on patch set 4 04/23/14, 08:53

  8. Wouter Wolters commented on patch set 4 04/23/14, 17:04

    PageRenderer.php:1844

    spaces are used here, make it a tab

    PageRenderer.php:1848

    space after if Make it === TRUE

    PageRenderer.php:1849

    space after foreach

    PageRenderer.php:1852

    spaces are used here make it a tab

    PageRenderer.php:2820

    This whole new code makes use of spaces, make it to tabs here
  9. Clément MICHELET uploaded patch set 5 04/24/14, 11:03

  10. Mr. Jenkins commented on patch set 5 04/24/14, 11:16

  11. Dmitry Dulepov commented on patch set 5 CR +1 04/28/14, 08:08

    PageRenderer.php:1850

    Why do you need a function here? Is it only for code completion? :)
  12. Clément MICHELET commented on patch set 5 05/05/14, 16:06

    PageRenderer.php:1850 Reply

    1) Some times ago I've found an article which talks about using methods instead of $GLOBALS in TYPO3 core. I don't remember where. 2) I'm not sure about the safety of using directly $GLOBALS['LANG'] in PageRenderer and if it has some performance issues. In my tests, it seems there is no issues. So, with a method, I'll just have to correct the code inside getLanguageService or elsewhere (initialization, ...) instead of inside of addInlineLanguageLabelArray 3) There are some hooks on PageRenderer with an instance as argument. If an hook need to access LanguageService, it has an accessor and 2) is not a problem at all. But if it's necessary to change to $GLOBALS['LANG'], I can switch to.
  13. Michael Oehlhof voted on patch set 5 CR +1 01/04/15, 01:02

  14. Thomas Deuling voted on patch set 5 CR +1 01/05/15, 11:21

  15. Benni Mack updated the commit message in patch set 6 03/01/15, 19:16

  16. Benni Mack commented on patch set 6 03/01/15, 19:16

    Hey Clement, care to update your patch?
  17. Michael Oehlhof voted on patch set 6 CR +1 03/01/15, 19:19

  18. Clément MICHELET commented on patch set 6 03/02/15, 10:08

    Hi Benjamin, I will try to update my patch this week.
  19. Michael Oehlhof uploaded patch set 7 03/18/15, 21:02

  20. Michael Oehlhof commented on patch set 7 CR +1 03/18/15, 21:03

    Solved merge conflict.
  21. Nicole Hummel uploaded patch set 8 03/19/15, 17:53

  22. Nicole Hummel voted on patch set 8 CR +1 V +1 03/19/15, 17:53

  23. Göran Bodenschatz voted on patch set 8 CR +1 03/19/15, 18:33

  24. Frank Nägler voted on patch set 8 V +2 CR +2 04/04/15, 19:41

  25. Frank Nägler merged patch set 8 04/04/15, 19:41