Review main Merged

29607[BUGFIX] TypoScriptParser does not validate absPath

Markus Klein CR +2 V +2 Easy +17 −13 updated 04/22/14, 19:43

Commit message

GeneralUtility::getFileAbsFileName() returns a blank string for
invalid paths.
TypoScriptParser::includeDirectory() does not check the return value,
but passes it on to TypoScriptParser::getAllFilesAndFoldersInPath().
This causes the method to enumerate all entries of /.

Fix this by properly checking the return value of getFileAbsFileName().

Review

  • Code review CR +2
    • Markus Klein +2
    • Stefan Neufeind +1
    • Johannes Kasberger +1
    • Wouter Wolters +1
  • Verified V +2
    • Markus Klein +2
    • Johannes Kasberger +1
    • Wouter Wolters +1

Issues 1

Files 1

Review log 7

  1. Johannes Kasberger voted on patch set 1 V +1 CR +1 04/22/14, 15:33

  2. Mr. Jenkins commented on patch set 1 04/22/14, 15:34

  3. Stefan Neufeind voted on patch set 1 CR +1 04/22/14, 18:44

  4. Wouter Wolters voted on patch set 1 V +1 04/22/14, 19:28

  5. Wouter Wolters voted on patch set 1 CR +1 04/22/14, 19:28

  6. Markus Klein voted on patch set 1 V +2 CR +2 04/22/14, 19:43

  7. Markus Klein merged patch set 2 04/22/14, 19:43