Review main Merged

29617[TASK] Reduce file size of core images

Bas van Beek CR +2 V +2 Easy +0 −0 updated 05/03/14, 22:15

Commit message

Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Christian Kuhn +1
  • Verified V +2
    • Anja Leichsenring +2
    • Nadir S. +1
    • Christian Kuhn +1

Issues 1

Files 3623

Show 3603 more files

Review log 18

  1. Mr. Jenkins commented on patch set 1 04/23/14, 11:46

  2. Markus Klein updated the commit message in patch set 1 04/23/14, 12:25

  3. Markus Klein updated the commit message in patch set 2 04/23/14, 12:28

  4. Markus Klein commented on patch set 3 04/23/14, 12:33

    Comparing the files locally I see that some of them actually got bigger.
  5. Mr. Jenkins commented on patch set 2 04/23/14, 12:40

  6. Mr. Jenkins commented on patch set 3 04/23/14, 12:43

  7. Nadir S. commented on patch set 3 V +1 05/03/14, 17:28

    it looks good to me. and i liked this optimisation. thank you for your work!
  8. Christian Kuhn commented on patch set 3 CR -1 05/03/14, 18:36

    in general, that looks good to me and i see no differences between before and after patch. the only images i would like to leave out are the TestReferences from install tool.
  9. Christian Kuhn commented on patch set 3 05/03/14, 18:40

    also, everything in typo3/contrib should be left out, imho.
  10. Christian Kuhn commented on patch set 3 05/03/14, 18:51

    will push update.
  11. Christian Kuhn uploaded patch set 4 05/03/14, 18:58

  12. Oliver Hader commented on patch set 4 05/03/14, 19:05

    What about? typo3/sysext/viewpage/Resources/Public/Css/ui-lightness/images/ typo3/sysext/extensionmanager/Resources/Public/Contrib/Farbtastic/
  13. Christian Kuhn commented on patch set 4 V +1 CR +1 05/03/14, 19:09

    imho, the two changes in the pathes mentioned by olly can stay.
  14. Nadir S. voted on patch set 4 V +1 05/03/14, 19:56

  15. Anja Leichsenring voted on patch set 4 V +2 CR +2 05/03/14, 20:02

  16. Anja Leichsenring merged patch set 5 05/03/14, 20:02

  17. Anja Leichsenring commented on patch set 5 05/03/14, 20:41

    Reverted This patchset was reverted in change: I21343c8273db1e5173d6b8211cc2fed510e9810e
  18. Mr. Jenkins commented on patch set 4 05/03/14, 22:15