Review main Merged

29618[FEATURE] Configurable width of the Element Browser Popups

Jigal van Hemert CR +2 V +2 Normal +53 −7 updated 12/21/14, 22:15

Commit message

The width of the element browser is sadly hardcoded to 600 and 650.

In many situations the element browser would need more place and
with this tiny change it would be easily possible to change
that behaviour without overloading the whole file.

The patch allows to set dimensions on a per-user basis via
userTSconfig.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Alexander Opitz +1
    • Anja Leichsenring +1
  • Verified V +2
    • Jigal van Hemert +2
    • Anja Leichsenring +1

Issues 3

Files 5

Review log 22

  1. Jigal van Hemert commented on patch set 1 CR -1 04/23/14, 11:42

    Please wait with this feature until we have a new master branch. Original was reverted per request of the RM because: - there is a feature freeze in the 6.2 branch - only regressions can be merged until a new master is made Besides: - there were not enough votes - the issue needs a documentation issue
  2. Mr. Jenkins commented on patch set 1 04/23/14, 11:52

  3. Wouter Wolters uploaded patch set 2 10/24/14, 08:15

  4. Wouter Wolters commented on patch set 2 V +1 CR +1 10/24/14, 08:21

    Rebased and added a RST file for the documentation.
  5. Felix Kopp commented on patch set 2 10/24/14, 18:03

    Hey everyone, thank you for the patch - but I don't see the use case of configuration of the dimensions of the Element Browser on a TCA field basis. In my opinion the EB is always the same size since the content is always of equal dimensions. Either with tabs or limited to since tab. Thus this only adds complexity which is not needed. The configuration of the EB dimensions should be system-wide.
  6. Benni Mack voted on patch set 2 CR +1 10/25/14, 09:50

  7. Benni Mack commented on patch set 2 10/25/14, 09:51

    thinking about felixes remarks, maybe configuration via userTSconfig makes more sense. And better defaults :)
  8. Benni Mack commented on patch set 2 CR -1 11/24/14, 18:25

    will come up with a new solution.
  9. Benni Mack uploaded patch set 3 12/15/14, 20:03

  10. Alexander Opitz commented on patch set 3 12/15/14, 20:49

    BackendController.php:484

    calculate like ($popupWindowWidth - 100)?

    BackendController.php:485

    calculate like ($popupWindowHeight - 250)?

    FormEngine.js:56

    Debug?
  11. Benni Mack uploaded patch set 4 12/17/14, 23:43

  12. Mathias Brodala commented on patch set 4 12/18/14, 08:31

    How about using Bootstrap modals instead of popups?
  13. Jigal van Hemert voted on patch set 4 CR +1 V +1 12/18/14, 08:38

  14. Benni Mack commented on patch set 4 12/18/14, 10:01

    Dmitry had a valid point (like 4 years ago) for not using modals for this: you cannot navigate (e.g. to another tab) while having the pagetree in the popup open. Additionally, we have ExtJS still in the pipes for the RTE. I can imagine that we could switch away once the RTE is fully migrated.
  15. Alexander Opitz commented on patch set 4 CR +1 12/18/14, 14:11

    Ok, looks better, but I'm no JS developer. I don't like that this isn't cool for tablets or such devices. Also we left 400x600 as hard coded numbers over.
  16. Benni Mack commented on patch set 4 12/18/14, 15:47

    Alexander, I agree, but this is out of scope for this patch, right?
  17. Alexander Opitz commented on patch set 4 12/21/14, 14:20

    That's right, that's why I voted + :)
  18. Anja Leichsenring uploaded patch set 5 12/21/14, 14:47

  19. Anja Leichsenring commented on patch set 5 V +1 CR +1 12/21/14, 14:49

    rebased
  20. Alexander Opitz voted on patch set 5 CR +1 12/21/14, 17:29

  21. Jigal van Hemert voted on patch set 5 CR +2 V +2 12/21/14, 22:15

  22. Jigal van Hemert merged patch set 5 12/21/14, 22:15