29618[FEATURE] Configurable width of the Element Browser Popups
Commit message
Review
-
Code review CR +2
- Jigal van Hemert +2
- Alexander Opitz +1
- Anja Leichsenring +1
-
Verified V +2
- Jigal van Hemert +2
- Anja Leichsenring +1
Issues 3
Files 5
- typo3/sysext/backend/Classes/Controller/BackendController.php2+24 −1
- typo3/sysext/backend/Resources/Public/JavaScript/FormEngine.js1+6 −2
- typo3/sysext/core/Documentation/Changelog/master/Feature-58031-ConfigurableWidthOfElementBrowser.rstnew+19 −0
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Image.js+2 −2
- typo3/sysext/rtehtmlarea/Resources/Public/JavaScript/Plugins/TYPO3Link.js+2 −2
Review log 22
-
Jigal van Hemert commented on patch set 1 CR -1 04/23/14, 11:42
Please wait with this feature until we have a new master branch. Original was reverted per request of the RM because: - there is a feature freeze in the 6.2 branch - only regressions can be merged until a new master is made Besides: - there were not enough votes - the issue needs a documentation issue -
Mr. Jenkins commented on patch set 1 04/23/14, 11:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16099/ : SUCCESS -
Wouter Wolters uploaded patch set 2 10/24/14, 08:15
-
Wouter Wolters commented on patch set 2 V +1 CR +1 10/24/14, 08:21
Rebased and added a RST file for the documentation. -
Felix Kopp commented on patch set 2 10/24/14, 18:03
Hey everyone, thank you for the patch - but I don't see the use case of configuration of the dimensions of the Element Browser on a TCA field basis. In my opinion the EB is always the same size since the content is always of equal dimensions. Either with tabs or limited to since tab. Thus this only adds complexity which is not needed. The configuration of the EB dimensions should be system-wide. -
Benni Mack voted on patch set 2 CR +1 10/25/14, 09:50
-
Benni Mack commented on patch set 2 10/25/14, 09:51
thinking about felixes remarks, maybe configuration via userTSconfig makes more sense. And better defaults :) -
Benni Mack commented on patch set 2 CR -1 11/24/14, 18:25
will come up with a new solution. -
Benni Mack uploaded patch set 3 12/15/14, 20:03
-
Alexander Opitz commented on patch set 3 12/15/14, 20:49
BackendController.php:484calculate like ($popupWindowWidth - 100)?BackendController.php:485calculate like ($popupWindowHeight - 250)?FormEngine.js:56Debug? -
Benni Mack uploaded patch set 4 12/17/14, 23:43
-
Mathias Brodala commented on patch set 4 12/18/14, 08:31
How about using Bootstrap modals instead of popups? -
Jigal van Hemert voted on patch set 4 CR +1 V +1 12/18/14, 08:38
-
Benni Mack commented on patch set 4 12/18/14, 10:01
Dmitry had a valid point (like 4 years ago) for not using modals for this: you cannot navigate (e.g. to another tab) while having the pagetree in the popup open. Additionally, we have ExtJS still in the pipes for the RTE. I can imagine that we could switch away once the RTE is fully migrated. -
Alexander Opitz commented on patch set 4 CR +1 12/18/14, 14:11
Ok, looks better, but I'm no JS developer. I don't like that this isn't cool for tablets or such devices. Also we left 400x600 as hard coded numbers over. -
Benni Mack commented on patch set 4 12/18/14, 15:47
Alexander, I agree, but this is out of scope for this patch, right? -
Alexander Opitz commented on patch set 4 12/21/14, 14:20
That's right, that's why I voted + :) -
Anja Leichsenring uploaded patch set 5 12/21/14, 14:47
-
Anja Leichsenring commented on patch set 5 V +1 CR +1 12/21/14, 14:49
rebased -
Alexander Opitz voted on patch set 5 CR +1 12/21/14, 17:29
-
Jigal van Hemert voted on patch set 5 CR +2 V +2 12/21/14, 22:15
-
Jigal van Hemert merged patch set 5 12/21/14, 22:15