29634[BUGFIX] Check if storage exists before accessing it
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Wouter Wolters +1
- Sebastian Fischer +1
- Frans Saris +1
-
Verified V +2
- Xavier Perseguers +2
- Sebastian Fischer +1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 04/24/14, 09:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16108/ : SUCCESS -
Frans Saris commented on patch set 1 04/24/14, 16:47
UserFileMountService.php:91I would prefer a flash message here with the message "storage: $storageUid is not found. No folder is currently selectable." -
Christian Weiske uploaded patch set 2 04/25/14, 07:38
-
Mr. Jenkins commented on patch set 2 CR -1 V -1 04/25/14, 07:51
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16119/ : FAILURE -
Christian Weiske uploaded patch set 3 04/25/14, 07:53
-
Mr. Jenkins commented on patch set 3 04/25/14, 08:06
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16120/ : SUCCESS -
Wouter Wolters commented on patch set 3 04/29/14, 17:59
One minor nitpick the rest looks ok to me.UserFileMountService.php:64$storage === NULL finbByUid returns null|ResourceStorage -
Christian Weiske commented on patch set 3 04/30/14, 06:35
UserFileMountService.php:64ReplyObjects in PHP always evaluate to true when being cast to boolean. -
Christian Weiske uploaded patch set 4 04/30/14, 06:37
-
Wouter Wolters voted on patch set 4 CR +1 04/30/14, 06:39
-
Mr. Jenkins commented on patch set 4 04/30/14, 06:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16159/ : SUCCESS -
Frans Saris voted on patch set 4 CR +1 05/02/14, 17:10
-
Sebastian Fischer voted on patch set 4 V +1 CR +1 05/03/14, 12:11
-
Xavier Perseguers voted on patch set 4 V +2 CR +2 05/12/14, 08:38
-
Xavier Perseguers merged patch set 5 05/12/14, 08:38