Review main Merged

29634[BUGFIX] Check if storage exists before accessing it

Christian Weiske CR +2 V +2 Easy +12 −1 updated 05/12/14, 08:38

Commit message

When editing a file mount in the backend, we need to check if
the storage backend actually exists.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Wouter Wolters +1
    • Sebastian Fischer +1
    • Frans Saris +1
  • Verified V +2
    • Xavier Perseguers +2
    • Sebastian Fischer +1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 04/24/14, 09:43

  2. Frans Saris commented on patch set 1 04/24/14, 16:47

    UserFileMountService.php:91

    I would prefer a flash message here with the message "storage: $storageUid is not found. No folder is currently selectable."
  3. Christian Weiske uploaded patch set 2 04/25/14, 07:38

  4. Mr. Jenkins commented on patch set 2 CR -1 V -1 04/25/14, 07:51

  5. Christian Weiske uploaded patch set 3 04/25/14, 07:53

  6. Mr. Jenkins commented on patch set 3 04/25/14, 08:06

  7. Wouter Wolters commented on patch set 3 04/29/14, 17:59

    One minor nitpick the rest looks ok to me.

    UserFileMountService.php:64

    $storage === NULL finbByUid returns null|ResourceStorage
  8. Christian Weiske commented on patch set 3 04/30/14, 06:35

    UserFileMountService.php:64 Reply

    Objects in PHP always evaluate to true when being cast to boolean.
  9. Christian Weiske uploaded patch set 4 04/30/14, 06:37

  10. Wouter Wolters voted on patch set 4 CR +1 04/30/14, 06:39

  11. Mr. Jenkins commented on patch set 4 04/30/14, 06:49

  12. Frans Saris voted on patch set 4 CR +1 05/02/14, 17:10

  13. Sebastian Fischer voted on patch set 4 V +1 CR +1 05/03/14, 12:11

  14. Xavier Perseguers voted on patch set 4 V +2 CR +2 05/12/14, 08:38

  15. Xavier Perseguers merged patch set 5 05/12/14, 08:38