Review main Merged

29643[FEATURE] Add dependencies between classes in RTE

Clément MICHELET CR +2 V +2 Normal +169 −30 updated 11/05/14, 18:48

Commit message

To comply with complex CSS frameworks like Twitter Bootstrap, we need
to add multiple classes on the same element. This adds complexity for
authors. With this new dependency feature, users just have to select
one style instead of many styles.

The syntax of this new property is:
    RTE.classes.[ *classname* ] {
        .requires = list of class names; list of classes that are
             required by the class;
             if this property, in combination with others, produces a
             circular relationship, it is ignored;
             when a class is added on an element, the classes it
             requires are also added, possibly recursively;
             when a class is removed from an element, any
             non-selectable class that is not required by any of the
             classes remaining on the element is also removed.
    }

Review

  • Code review CR +2
    • Stanislas Rolland +2
  • Verified V +2
    • Stanislas Rolland +2

Issues 1

Files 4

Review log 10

  1. Mr. Jenkins commented on patch set 1 04/24/14, 16:17

  2. Stanislas Rolland uploaded patch set 2 10/25/14, 18:30

  3. Stanislas Rolland wrote 10/25/14, 18:31

    Topic set to rtehtmlarea
  4. Stefan Froemken commented on patch set 2 10/26/14, 18:36

    When I remove a class, all related required classes were not removed. Further in class-attribute we have another ordering of the classes than given in pageTSconfig.
  5. Stanislas Rolland commented on patch set 2 10/26/14, 19:08

    @Stefan: when a class is removed from an element, any non-selectable class that is not required by any of the classes remaining on the element is also removed. Other classes remain on the element.
  6. Stanislas Rolland uploaded patch set 3 10/26/14, 21:35

  7. Stanislas Rolland commented on patch set 3 10/26/14, 21:37

    Patch Set 3 should fix the ordering issue and other misbehaviours.
  8. Stanislas Rolland uploaded patch set 4 11/05/14, 15:47

  9. Stanislas Rolland voted on patch set 4 CR +2 V +2 11/05/14, 18:48

  10. Stanislas Rolland merged patch set 4 11/05/14, 18:48