29656[BUGFIX] EXT:saltedpasswords remove dependency on EXT:setup
Commit message
Review
-
Code review CR +2
- Christian Kuhn +2
- Nicole Hummel +1
-
Verified V +2
- Christian Kuhn +2
- Nicole Hummel +1
Issues 1
Files 5
- typo3/sysext/rsaauth/Classes/Hook/UserSetupHook.php2+1 −1
- typo3/sysext/saltedpasswords/Classes/Utility/ExtensionManagerConfigurationUtility.php1+1 −3
- typo3/sysext/saltedpasswords/ext_tables.php+0 −3
- typo3/sysext/setup/Classes/Controller/SetupModuleController.php3+3 −6
- typo3/sysext/setup/ext_tables.php+0 −2
Review log 33
Show 8 earlier messages
-
Mr. Jenkins commented on patch set 1 04/25/14, 13:39
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16124/ : SUCCESS -
Johannes Kasberger voted on patch set 1 V +1 CR +1 04/25/14, 13:49
-
Oliver Klee commented on patch set 1 04/25/14, 20:15
ext_emconf.php:36The indentation here seems to be partly with spaces instead of with tabs. -
Markus Klein uploaded patch set 2 04/26/14, 08:28
-
Markus Klein commented on patch set 1 04/26/14, 08:28
ext_emconf.php:36Reply*Sigh*, new version coming. Don't know why PHPstorm doesn't use tabs here. -
Mr. Jenkins commented on patch set 2 04/26/14, 08:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16126/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 V +2 CR +2 04/28/14, 07:26
Tested, everything works. -
Wouter Wolters voted on patch set 2 CR +1 04/29/14, 17:43
-
Stefan Neufeind voted on patch set 2 CR +1 04/29/14, 22:07
-
Marcin Sągol voted on patch set 2 CR +1 05/04/14, 07:51
-
Christian Kuhn commented on patch set 2 CR +1 05/04/14, 08:05
Sounds and reads reasonable to me, did not really test yet, though. -
Nicole Hummel commented on patch set 2 V -1 05/04/14, 08:51
I'm unable to reproduce the issue. saltedpasswords registers an own eval function in be_users function which salts the new password before writing in database. -
Christian Kuhn commented on patch set 2 CR -1 05/04/14, 08:54
Can't we just unset the setting in ext:setup from "md5" to "" like ext:saltedPassword does, and remove the two lines from saltedPasswords ext_tables? This would work since ext:setup can rely on ext:saltedpassword to be loaded. -
Nicole Hummel uploaded patch set 3 05/04/14, 09:07
-
Nicole Hummel commented on patch set 3 05/04/14, 09:09
@Markus: I guess you installed an extension which overwrites the $GLOBALS['TCA']['be_users']['columns']['password']['config']['eval'] field -
Markus Klein commented on patch set 3 05/04/14, 14:54
@Nicole: No I did not. I tested this on my blank 6.2 master back then. What did you test? Did you see my instructions in forge? I'm fine with the current solution as well. But can we simply remove the md5 default? If so, we can also remove some code that is not needed anymore then, afaik. -
Mr. Jenkins commented on patch set 3 05/04/14, 16:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16271/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16267/ : SUCCESS -
Nicole Hummel uploaded patch set 4 05/04/14, 17:12
-
Nicole Hummel commented on patch set 4 05/04/14, 17:17
@Markus: I had a look again and can verify your problem now. There was a salted hash in the DB but it was prefixed with M which means that this is a md5 hash. The patch itself is save as saltedpasswords registers an eval function to store the user passwords salted by default now in the database. -
Markus Klein voted on patch set 4 V +1 CR +1 05/04/14, 18:22
-
Markus Klein commented on patch set 4 CR 0 05/04/14, 18:23
ExtensionManagerConfigurationUtility.php:224The br seems superfluous -
Markus Klein uploaded patch set 5 05/04/14, 18:34
-
Markus Klein updated the commit message in patch set 5 05/04/14, 18:37
-
Nicole Hummel commented on patch set 6 CR -1 05/04/14, 19:57
UserSetupHook.php:61rsaauth is not meant to be changed within this patch. This should go into another cleanup patch.SetupModuleController.php:510This has nothing to do with the issue and should go into another clean up patch. -
Markus Klein commented on patch set 6 05/04/14, 20:57
UserSetupHook.php:61Replyoh ok, overlooked that one. But it's just fixing a comment. Doesn't hurt to keep it here. hm?SetupModuleController.php:510ReplyHas only to do with this patch. Since we change the default, there's no need for md5 processing anymore. So IMO this has to be changed with this changeset. -
Mr. Jenkins commented on patch set 4 05/04/14, 23:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16300/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16296/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/05/14, 01:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16305/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16301/ : SUCCESS -
Nicole Hummel uploaded patch set 7 05/06/14, 00:04
-
Nicole Hummel voted on patch set 7 V +1 CR +1 05/06/14, 00:08
-
Mr. Jenkins commented on patch set 7 05/06/14, 00:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16341/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16337/ : SUCCESS -
Markus Klein commented on patch set 7 05/06/14, 09:21
SetupModuleController.php:501according to CGL we have to annotate the intended fall-through. that's why I added the comment in the last patch set. But I don't mind anymore here, just let this go in. -
Christian Kuhn voted on patch set 7 V +2 CR +2 05/06/14, 12:08
-
Christian Kuhn merged patch set 8 05/06/14, 12:08