Review main Merged

29696[BUGFIX] checkMaximumFileUploadSize shows misleading message

Markus Klein CR +2 V +2 Easy +7 −9 updated 06/30/14, 11:39

Commit message

Improve the Install Tool system environment check for
PHP maximum upload size.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Stefan Froemken +1
    • Jost Baron +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Froemken +1
    • Jost Baron +1

Issues 1

Files 1

Review log 12

  1. Mr. Jenkins commented on patch set 1 04/27/14, 18:13

  2. Jost Baron voted on patch set 1 V +1 CR +1 04/27/14, 18:39

  3. Wouter Wolters voted on patch set 1 CR +1 04/29/14, 17:52

  4. Stefan Froemken voted on patch set 1 V +1 CR +1 04/30/14, 08:51

  5. Stefan Neufeind voted on patch set 1 CR +1 04/30/14, 10:39

  6. Wouter Wolters voted on patch set 1 V +2 CR +2 04/30/14, 17:40

  7. Wouter Wolters merged patch set 2 04/30/14, 17:40

  8. Christian Kuhn commented on patch set 2 06/29/14, 21:57

    post -2. The patch adds access to TYPO3 specific $GLOBALS variables which is NOT allowed in this class.
  9. Stefan Neufeind commented on patch set 2 06/29/14, 22:15

    too bad it took two months :-(
  10. Christian Kuhn commented on patch set 2 06/30/14, 10:15

    5 people on this patch an nobody read the class comment?
  11. Markus Klein commented on patch set 2 06/30/14, 10:43

    @Christian: Yes, I really didn't read the class comment, sorry for that. But, I see no other way to solve this, such that an average user is informed about the problem before he runs into it when installing a fresh instance. If you have a good idea, please let me know, I'll happily cleanup my "dirty hack".
  12. Stefan Neufeind commented on patch set 2 06/30/14, 11:39

    @Christian: Yes, I didn't see the comment, since it doesn't (easily) show in gerrit - unless you explicitly search for it.