29696[BUGFIX] checkMaximumFileUploadSize shows misleading message
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
- Stefan Froemken +1
- Jost Baron +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Froemken +1
- Jost Baron +1
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 04/27/14, 18:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16129/ : SUCCESS -
Jost Baron voted on patch set 1 V +1 CR +1 04/27/14, 18:39
-
Wouter Wolters voted on patch set 1 CR +1 04/29/14, 17:52
-
Stefan Froemken voted on patch set 1 V +1 CR +1 04/30/14, 08:51
-
Stefan Neufeind voted on patch set 1 CR +1 04/30/14, 10:39
-
Wouter Wolters voted on patch set 1 V +2 CR +2 04/30/14, 17:40
-
Wouter Wolters merged patch set 2 04/30/14, 17:40
-
Christian Kuhn commented on patch set 2 06/29/14, 21:57
post -2. The patch adds access to TYPO3 specific $GLOBALS variables which is NOT allowed in this class. -
Stefan Neufeind commented on patch set 2 06/29/14, 22:15
too bad it took two months :-( -
Christian Kuhn commented on patch set 2 06/30/14, 10:15
5 people on this patch an nobody read the class comment? -
Markus Klein commented on patch set 2 06/30/14, 10:43
@Christian: Yes, I really didn't read the class comment, sorry for that. But, I see no other way to solve this, such that an average user is informed about the problem before he runs into it when installing a fresh instance. If you have a good idea, please let me know, I'll happily cleanup my "dirty hack". -
Stefan Neufeind commented on patch set 2 06/30/14, 11:39
@Christian: Yes, I didn't see the comment, since it doesn't (easily) show in gerrit - unless you explicitly search for it.