Review main Abandoned

29710[BUGFIX] EXT:version: Generate SQL correctly without EXT:workspaces

Stefan Neufeind CR 0 V 0 Easy +8 −3 updated 09/20/14, 18:09

Commit message

Only add a workspaces-subclause if EXT:workspaces is actually
loaded.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 16

  1. Stefan Neufeind commented on patch set 1 04/28/14, 10:38

    so far untested SQL-string was introduced into 6.2 by Olly with commit 2b4f543f56fb36916443150a2d09e240a26d06b8
  2. Markus Klein commented on patch set 1 04/28/14, 10:44

  3. Jo Hasenau voted on patch set 1 CR +1 04/28/14, 10:48

  4. Mr. Jenkins commented on patch set 1 04/28/14, 10:50

  5. Markus Klein commented on patch set 1 CR -1 04/28/14, 10:53

    ElementEntity.php:255

    same here
  6. Markus Klein uploaded patch set 2 04/28/14, 10:55

  7. Jo Hasenau voted on patch set 2 CR +1 04/28/14, 10:56

  8. Stefan Neufeind voted on patch set 2 CR +1 04/28/14, 10:58

  9. Markus Klein voted on patch set 2 CR +1 04/28/14, 10:59

  10. Mr. Jenkins commented on patch set 2 04/28/14, 11:13

  11. Oliver Hader commented on patch set 2 CR -2 04/28/14, 11:25

    The field "workspaces" of the table "sys_refindex" is defined in the "core" system extension. Please upgrade SQL schema first before modifying the codes...
  12. Wouter Wolters commented on patch set 2 V -1 CR -1 04/29/14, 17:39

    Oliver is right here, see below from ext_tables.sql in EXT:core: # # Table structure for table 'sys_refindex' # CREATE TABLE sys_refindex ( hash varchar(32) DEFAULT '' NOT NULL, tablename varchar(255) DEFAULT '' NOT NULL, recuid int(11) DEFAULT '0' NOT NULL, field varchar(40) DEFAULT '' NOT NULL, flexpointer varchar(255) DEFAULT '' NOT NULL, softref_key varchar(30) DEFAULT '' NOT NULL, softref_id varchar(40) DEFAULT '' NOT NULL, sorting int(11) DEFAULT '0' NOT NULL, deleted tinyint(1) DEFAULT '0' NOT NULL, workspace int(11) DEFAULT '0' NOT NULL, ref_table varchar(255) DEFAULT '' NOT NULL, ref_uid int(11) DEFAULT '0' NOT NULL, ref_string varchar(200) DEFAULT '' NOT NULL, PRIMARY KEY (hash), KEY lookup_rec (tablename,recuid), KEY lookup_uid (ref_table,ref_uid), KEY lookup_string (ref_string) );
  13. Jo Hasenau commented on patch set 2 04/29/14, 18:21

    So what is the expected solution now? - Move workspace fields from core SQL files to workspace specific SQL files?
  14. Wouter Wolters commented on patch set 2 04/29/14, 18:32

    workspace field is by default zero, so I expect that when only ext:version is used the workspace id returned from dependency is also zero. So there shouldn't be a problem if that is true.
  15. Stefan Neufeind commented on patch set 2 CR -1 04/29/14, 22:10

    I know that I had exceptions because EXT:workspaces was not loaded (pointing to a missing column). Will need to retest that sometime soon hopefully ...
  16. Stefan Neufeind abandoned the change 09/20/14, 18:09

    Didn't manage to reproduce it anymore on current master. Thanks for taking a look though.