29722[BUGFIX] Reimplement ranges in NumberRangeValidator
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
-
Verified V +2
- Markus Klein +2
- Wouter Wolters +1
Issues 1
Files 2
Review log 31
Show 6 earlier messages
-
Markus Klein updated the commit message in patch set 1 04/29/14, 08:58
-
Markus Klein updated the commit message in patch set 2 04/29/14, 09:07
-
Markus Klein voted on patch set 3 CR +1 04/29/14, 09:07
-
Andreas Allacher voted on patch set 3 CR +1 04/29/14, 09:10
-
Mr. Jenkins commented on patch set 1 04/29/14, 09:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16143/ : SUCCESS -
Mr. Jenkins commented on patch set 2 04/29/14, 09:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16144/ : SUCCESS
-
Oliver Hader commented on patch set 3 04/29/14, 09:18
Will update tests... -
Mr. Jenkins commented on patch set 3 04/29/14, 09:29
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16146/ : SUCCESS -
Oliver Hader uploaded patch set 4 04/29/14, 09:34
-
Oliver Hader commented on patch set 4 V +1 CR +2 04/29/14, 09:35
Added unit test for the deprecated options -
Mr. Jenkins commented on patch set 4 04/29/14, 09:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16148/ : SUCCESS -
Markus Klein voted on patch set 4 V +1 CR +1 04/29/14, 10:02
-
Stefan Froemken uploaded patch set 5 04/29/14, 12:14
-
Markus Klein commented on patch set 5 04/29/14, 12:27
NumberRangeValidator.php:76Hm had a look at this. The base class always sets all supportedOptions in the $this->options array. So the isset() check is always TRUE. -
Mr. Jenkins commented on patch set 5 04/29/14, 12:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16149/ : SUCCESS -
Stefan Froemken uploaded patch set 6 04/29/14, 14:36
-
Markus Klein commented on patch set 6 04/29/14, 14:45
Please discuss a solution first before pushing new patch sets. ;-)NumberRangeValidator.php:72Why the empty check now?? -
Mr. Jenkins commented on patch set 6 04/29/14, 14:49
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16150/ : SUCCESS -
Stefan Froemken commented on patch set 6 04/29/14, 15:02
NumberRangeValidator.php:72ReplyWhat do you think? Remove the complete &&-part? -
Markus Klein commented on patch set 6 04/29/14, 15:08
NumberRangeValidator.php:72ReplySure, we don't need it at all. The option is always set and the value is either the default value or the one specified by the user. -
Stefan Froemken uploaded patch set 7 04/29/14, 15:20
-
Mr. Jenkins commented on patch set 7 04/29/14, 15:43
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16151/ : SUCCESS -
Wouter Wolters commented on patch set 7 V -1 04/29/14, 17:29
PHP Fatal error: Call to a member function exec_SELECTgetSingleRow() on a non-object in /var/www/websites/master/htdocs/typo3/sysext/core/Classes/Cache/Backend/Typo3DatabaseBackend.php on line 182 When running unittests -
Markus Klein commented on patch set 7 04/29/14, 18:08
Ok the problem is that setOptions() allows to circumvent the preparations in the constructor. We need to keep the checks that protect us from this. -
Markus Klein uploaded patch set 8 04/29/14, 18:12
-
Markus Klein voted on patch set 8 V +1 CR +1 04/29/14, 18:13
-
Mr. Jenkins commented on patch set 8 04/29/14, 18:27
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16156/ : SUCCESS -
Wouter Wolters voted on patch set 8 V +1 CR +1 04/29/14, 18:29
-
Markus Klein commented on patch set 8 V +2 CR +2 04/29/14, 21:14
As this is a regression, I'm merging. -
Markus Klein merged patch set 9 04/29/14, 21:14
-
Stephan Großberndt commented on patch set 9 12/03/15, 12:39
Post -1 The code always uses the default values of "minimum" and "maximum". If you use * @validate NumberRange (startRange = 0, endRange = 2) this will never be checked, but the default values from $this->supportedOptions of minimum/maximum