Review main Merged

29730[BUGFIX] Admin panel extGetFeAdminValue() overrides are wrong

Markus Klein CR +2 V +2 Normal +25 −27 updated 06/05/14, 20:57

Commit message

The current check does not properly consider the override values.
If a override is set, then its value has to be taken.
The current check only considered overrides which had
boolean value TRUE.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
    • Gerrit Mohrmann +1
  • Verified V +2
    • Wouter Wolters +2
    • Gerrit Mohrmann +1

Issues 1

Files 1

Review log 6

  1. Wouter Wolters voted on patch set 1 CR +1 04/29/14, 17:03

  2. Mr. Jenkins commented on patch set 1 04/29/14, 17:13

  3. Gerrit Mohrmann voted on patch set 1 V +1 CR +1 04/29/14, 17:48

  4. Stefan Neufeind voted on patch set 1 CR +1 04/30/14, 10:50

  5. Wouter Wolters voted on patch set 1 V +2 CR +2 06/05/14, 20:57

  6. Wouter Wolters merged patch set 2 06/05/14, 20:57