Review main Merged

2975[FEATURE] Show the faulty URL when an extension cannot be fetched

Xavier Perseguers CR +2 V +2 Easy +1 −1 updated 06/03/13, 20:49

Commit message

When EM fails to fetch an extension, it returns an error message
without showing the faulty URL which makes it difficult to adapt
firewall configuration if needed.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Mario Rimann +1
    • Andy Grunwald +1
  • Verified V +2
    • Xavier Perseguers +2

Issues 1

Files 1

Review log 10

  1. Xavier Perseguers commented on patch set 1 07/03/11, 12:54

    (1 inline comment)
  2. Mario Rimann commented on patch set 2 07/03/11, 12:54

    Looks good to me, but someone else must approve
  3. Xavier Perseguers uploaded patch set 2 07/03/11, 12:54

  4. Xavier Perseguers commented on patch set 2 V 0 07/03/11, 12:54

    by team member; Looks good to me, approved
  5. Georg Ringer commented on patch set 1 07/03/11, 12:54

    Verified; Looks good to me, approved

    class.tx_em_connection_ter.php:70

    wanna rename that to cURL? IMO it is called "Install Tool" with upper T ?
  6. Andy Grunwald commented on patch set 1 07/03/11, 12:54

    Looks good to me, but someone else must approve Small but necessary improvement
  7. Andy Grunwald commented on patch set 2 07/03/11, 12:54

    Looks good to me, but someone else must approve
  8. Mr. Jenkins commented on patch set 1 07/03/11, 12:54

  9. Mr. Jenkins commented on patch set 2 07/03/11, 12:54

  10. Xavier Perseguers merged patch set 2 07/03/11, 12:54