Review main Merged

29809[BUGFIX] Remove hardcoded calling script in help controller

Helmut Hummel CR +2 V +2 Easy +34 −9 updated 05/03/14, 14:58

Commit message

The Extbase help command controller has the calling
script hardcoded in several places. This may cause
confusion if the calling script was different.

Use the real script from argv[0] instead.

Review

  • Code review CR +2
    • Anja Leichsenring +2
    • Wouter Wolters +1
  • Verified V +2
    • Anja Leichsenring +2
    • Wouter Wolters +1

Issues 1

Files 4

Review log 8

  1. Wouter Wolters voted on patch set 1 CR +1 05/03/14, 13:14

  2. Helmut Hummel uploaded patch set 2 05/03/14, 13:15

  3. Helmut Hummel commented on patch set 2 05/03/14, 13:16

    changed the default value of the calling script in request builder to be the same as before
  4. Wouter Wolters commented on patch set 2 V +1 CR +1 05/03/14, 13:23

    Tested by calling it from an level higher. It displayed nicely in the message.
  5. Anja Leichsenring voted on patch set 2 V +2 CR +2 05/03/14, 14:16

  6. Anja Leichsenring merged patch set 3 05/03/14, 14:16

  7. Mr. Jenkins commented on patch set 1 05/03/14, 14:44

  8. Mr. Jenkins commented on patch set 2 05/03/14, 14:58