Review main Merged

29814[BUGFIX] AbstractDomainObject _cleanProperties is array

mostwanted CR +2 V +2 Easy +2 −9 updated 05/03/14, 20:14

Commit message

Properly initialize _cleanProperties to array to prevent warnings.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • Oliver Klee +1
    • Christian Kuhn +1
  • Verified V +2
    • Marc Bastian Heinrichs +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 13

  1. mostwanted commented on patch set 1 05/03/14, 14:02

    AbstractDomainObject.php:241

    Is there a way to ensure that $this->_cleanProperties is an array in the first place?
  2. mostwanted uploaded patch set 2 05/03/14, 14:03

  3. mostwanted commented on patch set 2 05/03/14, 14:04

    AbstractDomainObject.php:67

    This looks more adequate than patch set 1, doesn't it?
  4. Oliver Klee voted on patch set 2 CR +1 05/03/14, 15:28

  5. Mr. Jenkins commented on patch set 1 05/03/14, 16:57

  6. Mr. Jenkins commented on patch set 2 05/03/14, 17:14

  7. Christian Kuhn uploaded patch set 3 05/03/14, 17:25

  8. Christian Kuhn voted on patch set 3 V +1 CR +1 05/03/14, 17:27

  9. Oliver Klee voted on patch set 3 CR +1 05/03/14, 17:32

  10. Marc Bastian Heinrichs wrote 05/03/14, 18:58

    Topic set to "Extbase".
  11. Marc Bastian Heinrichs voted on patch set 3 V +2 CR +2 05/03/14, 19:02

  12. Marc Bastian Heinrichs merged patch set 4 05/03/14, 19:02

  13. Mr. Jenkins commented on patch set 3 05/03/14, 20:14