Review main Merged

29815[TASK] Add phpdoc @var for calls to makeInstance()

mostwanted CR +2 V +2 Easy +11 −1 updated 05/03/14, 19:58

Commit message

Review

  • Code review CR +2
    • Christian Kuhn +2
  • Verified V +2
    • Christian Kuhn +2

Issues 2

Files 11

Review log 9

  1. Oliver Klee commented on patch set 1 05/03/14, 15:22

    AFAIK, the variable name should come first, and then the class name (although PhpStorm's template is the other way around). I'm not quite sure which way supports more IDEs. Roland, do you happen to know more about this?
  2. Oliver Klee commented on patch set 1 CR +1 05/03/14, 15:27

    Okay, after some googling around, it seems that having the type first is the more common way, but both orders seem to work.
  3. mostwanted commented on patch set 1 05/03/14, 16:24

    I used the style phpstorm suggests after typing /** @var
  4. Christian Kuhn commented on patch set 1 05/03/14, 16:41

    MysqlFulltextIndexHook.php:177

    twice?
  5. Christian Kuhn uploaded patch set 2 05/03/14, 16:46

  6. Christian Kuhn voted on patch set 2 V +2 CR +2 05/03/14, 16:47

  7. Christian Kuhn merged patch set 3 05/03/14, 16:47

  8. Mr. Jenkins commented on patch set 1 05/03/14, 17:29

  9. Mr. Jenkins commented on patch set 2 05/03/14, 19:58