Review main Merged

29829[TASK] Reduce file size of core images

Anja Leichsenring CR +2 V +2 Easy +0 −0 updated 07/25/14, 12:49

Commit message

Reduce the file size without losing quality.
This reduces total typo3 directory size by ~2 MB.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 864

Show 844 more files

Review log 26

Show 1 earlier messages
  1. Anja Leichsenring uploaded patch set 2 05/03/14, 20:46

  1. Anja Leichsenring commented on patch set 2 V -1 05/03/14, 20:47

    file permissions are wrong, and impexp functional tests fail due to changed images.
  2. Mr. Jenkins commented on patch set 2 CR -1 V -1 05/04/14, 01:22

  3. Stefan Neufeind commented on patch set 2 05/30/14, 00:22

    Could somebody update this patch, maybe?
  4. Bas van Beek voted on patch set 2 V +1 CR +1 06/11/14, 15:41

  5. Bas van Beek voted on patch set 2 V +1 06/11/14, 15:41

  6. Bas van Beek commented on patch set 2 06/11/14, 15:41

    What is next?
  7. Stephan Großberndt commented on patch set 2 06/12/14, 17:13

    I think, Mr. Jenkins should verify your new patch automatically, but this did not happen (yet?).
  8. Stefan Neufeind commented on patch set 2 06/12/14, 18:05

    Patchset 2 was already voted upon by Jenkins. And Anja wrote some permission-problems were the result of Jenkins giving -1. I haven't looked into it, but maybe it needs fetching the patch, fixing those issues and repushing to get things to normal state.
  9. Stefan Neufeind commented on patch set 2 07/06/14, 17:31

    ping
  10. Anja Leichsenring uploaded patch set 3 07/25/14, 09:54

  11. Anja Leichsenring commented on patch set 3 V -1 07/25/14, 09:56

    working on it
  12. Anja Leichsenring uploaded patch set 4 07/25/14, 09:59

  13. Anja Leichsenring commented on patch set 3 07/25/14, 10:00

    still working on it
  14. Anja Leichsenring voted on patch set 4 V -1 07/25/14, 10:01

  15. Anja Leichsenring uploaded patch set 5 07/25/14, 11:13

  16. Anja Leichsenring commented on patch set 5 CR +1 V +1 07/25/14, 11:17

    I removed all the files from the commit, that not actually decraese in size. Additionally I fixed the file permissions back to standard, which were changed with the original patchset. Now some functional tests fail due to the files changed. I will fix this with a follow up patch.
  17. Markus Klein commented on patch set 5 CR +1 07/25/14, 11:24

    Since the gerrit interface does not show me the sizes of the old/new files, I can only trust Anja.
  18. Anja Leichsenring commented on patch set 5 07/25/14, 11:31

    in a Unix System, you can create a file, that is included in your path like this: cat ~/bin/git-file-size-diff #!/bin/sh . git-sh-setup args=$(git rev-parse --sq "$@") eval "git diff-tree -r $args" | { total=0 while read A B C D M P do case $M in M) bytes=$(( $(git cat-file -s $D) - $(git cat-file -s $C) )) ;; A) bytes=$(git cat-file -s $D) ;; D) bytes=-$(git cat-file -s $C) ;; *) echo >&2 warning: unhandled mode $M in \"$A $B $C $D $M $P\" continue ;; esac total=$(( $total + $bytes )) printf '%d\t%s\n' $bytes "$P" done echo total $total } Then apply the patch in an early patchset and run in the git root git file-size-diff <commithash>. The output will show lots of files with a differenz of zero or positive numbers. Those grow larger compared to HEAD~1. When you apply the latest patchset, only negative numbers are displayed. Those files are smaller now.
  19. Stefan Neufeind commented on patch set 5 07/25/14, 11:35

    filed an issue against gerrit against no filesizes displayed although such a column exists: https://forge.typo3.org/issues/60560
  20. Anja Leichsenring uploaded patch set 6 07/25/14, 12:01

  21. Christian Kuhn voted on patch set 6 CR +1 V +1 07/25/14, 12:31

  22. Susi Moog voted on patch set 6 CR +1 V +1 07/25/14, 12:31

  23. Christian Kuhn voted on patch set 6 CR +2 V +2 07/25/14, 12:31

  24. Christian Kuhn merged patch set 6 07/25/14, 12:32

  25. Stefan Neufeind commented on patch set 7 07/25/14, 12:49

    Backport to 6.2? The files should be equal I expect (have they changed since we branched off?), a reduced size makes a smaller distribution/faster download and possibly a faster BE imho.