Review main Merged

29848[CLEANUP] Clean up functional tests

Felix Oertel CR +2 V +2 Hard +0 −540 updated 05/06/14, 16:50

Commit message

To allow running of all functional tests, instead of
relying on travis.yml, we want to clean up broken and
abandoned tests.

So we remove the tests that fatal because they are not
meant to be used in the functional testing framework.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Anja Leichsenring +1
    • Jan Helke +1
  • Verified V +2
    • Christian Kuhn +2
    • Anja Leichsenring +1

Issues 1

Files 5

Review log 11

  1. Christian Kuhn commented on patch set 1 05/04/14, 12:52

    ClassImplementationRegistrationTest.php:38

    those tests could maybe be activated. they basically test if the xclass object registration is successful.
  2. Wouter Wolters commented on patch set 1 05/04/14, 12:53

    6.2
  3. Felix Oertel updated the commit message in patch set 1 05/04/14, 13:22

  4. Anja Leichsenring voted on patch set 2 V +1 CR +1 05/04/14, 14:16

  5. Christian Kuhn voted on patch set 2 CR -1 05/04/14, 14:19

  6. Mr. Jenkins commented on patch set 1 05/04/14, 19:44

  7. Mr. Jenkins commented on patch set 2 05/04/14, 21:29

  8. Christian Kuhn commented on patch set 2 V +1 CR +1 05/06/14, 16:45

    Ok, tried to activate the dbal functionals, but dbal itself seems to give headaches with establishing the db connection. Since the tests are not *that* useful either, (they actually basically only test if the xclass registration is correct), imho they can be removed, too. So, +1 for this patch now.
  9. Jan Helke voted on patch set 2 CR +1 05/06/14, 16:49

  10. Christian Kuhn voted on patch set 2 V +2 CR +2 05/06/14, 16:50

  11. Christian Kuhn merged patch set 3 05/06/14, 16:50