Review main Merged

29859[BUGFIX] saltedpasswords: Check rsaauth loading

Nicole Hummel CR +2 V +2 Easy +16 −6 updated 05/05/14, 03:49

Commit message

This patch adds the loading check of rsaauth before trying to access the
BackendFactory of rsaauth. Otherwise the extension manager gets broken
on entering extension configuration.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Markus Klein +1
    • Nicole Hummel +1
  • Verified V +2
    • Jigal van Hemert +2
    • Nicole Hummel +1

Issues 1

Files 1

Review log 20

  1. Markus Klein updated the commit message in patch set 1 05/04/14, 18:06

  2. Markus Klein commented on patch set 2 V -1 CR -1 05/04/14, 18:10

    This is the wrong approach. Please check the usage of the isRsaAuthBackendAvailable() function. It is used to output information about the usability of the saltedpasswords extension. (checkConfigurationBackend() and checkConfigurationFrontend()) Letting the function return FALSE, will cause the output to contain error-level output, which is wrong as rsaauth is optional. Hence another check is necessary.
  3. Nicole Hummel commented on patch set 2 05/04/14, 18:17

    If you read the error message it says that rsaauth might not work and your password are not encrypted. Maybe this should not shown as error, but this is not the approach of this patch!
  4. Markus Klein commented on patch set 2 05/04/14, 18:20

    The error message shown is: "Using the extension "rsaauth" is not possible, as no encryption backend is available. Please install and configure the PHP extension "openssl"". This is completely wrong. The correct check would be to verify that rsaauth is loaded at all if ['FE'/'BE']['loginSecurityLevel']) = 'rsa' is set.
  5. Markus Klein uploaded patch set 3 05/04/14, 18:50

  6. Nicole Hummel uploaded patch set 4 05/04/14, 18:54

  7. Markus Klein uploaded patch set 5 05/04/14, 19:05

  8. Markus Klein uploaded patch set 6 05/04/14, 19:06

  9. Markus Klein commented on patch set 5 05/04/14, 19:06

    adjusting some spaces
  10. Markus Klein voted on patch set 6 CR +1 05/04/14, 19:06

  11. Nicole Hummel voted on patch set 6 V +1 CR +1 05/04/14, 20:02

  12. Jigal van Hemert voted on patch set 6 V +2 CR +2 05/04/14, 20:03

  13. Jigal van Hemert merged patch set 7 05/04/14, 20:03

  14. Jigal van Hemert commented on patch set 7 05/04/14, 20:09

    Cherry Picked This patchset was cherry picked to change: I197fb5e032b31e6add388269f77e6fc834e45b54
  15. Mr. Jenkins commented on patch set 1 05/05/14, 00:47

  16. Mr. Jenkins commented on patch set 2 05/05/14, 01:16

  17. Mr. Jenkins commented on patch set 3 05/05/14, 02:17

  18. Mr. Jenkins commented on patch set 4 05/05/14, 02:46

  19. Mr. Jenkins commented on patch set 5 05/05/14, 03:16

  20. Mr. Jenkins commented on patch set 6 05/05/14, 03:49