29881[BUGFIX] Remove warnings in ImportExportController.php
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Wouter Wolters +1
- Christian Kuhn +1
- Susi Moog +1
-
Verified V +2
- Markus Klein +2
- Christian Kuhn +1
Issues 1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 05/05/14, 20:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16338/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16334/ : SUCCESS -
Markus Klein voted on patch set 1 V +1 CR +1 05/05/14, 21:22
-
Christian Kuhn commented on patch set 1 05/06/14, 20:10
How to reproduce? -
Christian Kuhn commented on patch set 1 05/06/14, 21:27
not 100% convinced here. idea looks sane, but i'm still unable to reproduce. maybe someone else could step in?. -
Wouter Wolters voted on patch set 1 CR +1 05/06/14, 21:34
-
Nicole Hummel commented on patch set 1 05/06/14, 23:32
ImportExportController.php:782As $inData['meta']['thumbnail'] is not set the LocalDriver tries to get fileInformation from a folder @see LocalDriver::getFileInfoByIdentifier ($fileIdentifier is empty) @see LocalDriver::getMimeTypeOfFile ($absoluteFilePath = root directory)ImportExportController.php:1463As my first defined storage is a read only non-LocalDriver storage it has no temporary folder defined and therefore NULL is returned. Because FALSE !== NULL there isn't any exit and getStorage() is called on NULL afterwards -
Markus Klein updated the commit message in patch set 1 06/17/14, 18:23
-
Markus Klein voted on patch set 2 V +1 CR +1 06/17/14, 18:23
-
Mr. Jenkins commented on patch set 2 06/17/14, 20:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16764/ : SUCCESS -
Susi Moog voted on patch set 2 CR +1 06/19/14, 15:48
-
Wouter Wolters voted on patch set 2 CR +1 06/19/14, 16:45
-
Christian Kuhn voted on patch set 2 V +1 CR +1 06/19/14, 17:06
-
Markus Klein voted on patch set 2 V +2 CR +2 06/19/14, 17:11
-
Markus Klein merged patch set 3 06/19/14, 17:11
-
Markus Klein commented on patch set 3 06/19/14, 17:11
Cherry Picked This patchset was cherry picked to change: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b