Review main Merged

29881[BUGFIX] Remove warnings in ImportExportController.php

Nicole Hummel CR +2 V +2 Easy +5 −2 updated 06/19/14, 17:11

Commit message

This patch adds cleanup to prevent warnings when accessing the
import/export module.

Review

  • Code review CR +2
    • Markus Klein +2
    • Wouter Wolters +1
    • Christian Kuhn +1
    • Susi Moog +1
  • Verified V +2
    • Markus Klein +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 05/05/14, 20:45

  2. Markus Klein voted on patch set 1 V +1 CR +1 05/05/14, 21:22

  3. Christian Kuhn commented on patch set 1 05/06/14, 20:10

    How to reproduce?
  4. Christian Kuhn commented on patch set 1 05/06/14, 21:27

    not 100% convinced here. idea looks sane, but i'm still unable to reproduce. maybe someone else could step in?.
  5. Wouter Wolters voted on patch set 1 CR +1 05/06/14, 21:34

  6. Nicole Hummel commented on patch set 1 05/06/14, 23:32

    ImportExportController.php:782

    As $inData['meta']['thumbnail'] is not set the LocalDriver tries to get fileInformation from a folder @see LocalDriver::getFileInfoByIdentifier ($fileIdentifier is empty) @see LocalDriver::getMimeTypeOfFile ($absoluteFilePath = root directory)

    ImportExportController.php:1463

    As my first defined storage is a read only non-LocalDriver storage it has no temporary folder defined and therefore NULL is returned. Because FALSE !== NULL there isn't any exit and getStorage() is called on NULL afterwards
  7. Markus Klein updated the commit message in patch set 1 06/17/14, 18:23

  8. Markus Klein voted on patch set 2 V +1 CR +1 06/17/14, 18:23

  9. Mr. Jenkins commented on patch set 2 06/17/14, 20:15

  10. Susi Moog voted on patch set 2 CR +1 06/19/14, 15:48

  11. Wouter Wolters voted on patch set 2 CR +1 06/19/14, 16:45

  12. Christian Kuhn voted on patch set 2 V +1 CR +1 06/19/14, 17:06

  13. Markus Klein voted on patch set 2 V +2 CR +2 06/19/14, 17:11

  14. Markus Klein merged patch set 3 06/19/14, 17:11

  15. Markus Klein commented on patch set 3 06/19/14, 17:11

    Cherry Picked This patchset was cherry picked to change: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b