29890[BUGFIX] Unit Tests: Only load system extensions with bootstrap
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 6
-
Christian Kuhn commented on patch set 1 CR -1 05/06/14, 08:51
Since 3rd party extensions should use the core bootstrap, too, it is required that their classes can be found as well. -
Mr. Jenkins commented on patch set 1 05/06/14, 09:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16344/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16340/ : SUCCESS -
Oliver Klee commented on patch set 1 CR -1 05/06/14, 09:27
UnitTestPackageManager.php:44Do we need a parent::construct here?UnitTestPackageManager.php:51If you want to stop the loop, this should be a break, not a continue. (The continue only skips the current loop iteration and goes directly to the next iteration). -
Christian Kuhn voted on patch set 1 CR -2 05/06/14, 09:56
-
Christian Kuhn commented on patch set 1 05/06/14, 10:05
If it is really required to have this (eg. because extensions in typo3conf/ext do broken stuff in ext_autoload.php), then we may add a environment variable that hints the autoloader to only include core stuff. -
Nicole Hummel abandoned the change 05/06/14, 10:22
System has to be clean