Review main Abandoned

29890[BUGFIX] Unit Tests: Only load system extensions with bootstrap

Nicole Hummel CR 0 V 0 Easy +31 −0 updated 05/06/14, 10:22

Commit message

This patch reduces the packagesBasePaths of the UnitTestPackageManager
to sysext only if phpunit is called with
typo3/sysext/core/Build/UnitTests.xml configuration. This is safe as it
means we running core tests only and prevents any error from local
existing extensions.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 6

  1. Christian Kuhn commented on patch set 1 CR -1 05/06/14, 08:51

    Since 3rd party extensions should use the core bootstrap, too, it is required that their classes can be found as well.
  2. Mr. Jenkins commented on patch set 1 05/06/14, 09:14

  3. Oliver Klee commented on patch set 1 CR -1 05/06/14, 09:27

    UnitTestPackageManager.php:44

    Do we need a parent::construct here?

    UnitTestPackageManager.php:51

    If you want to stop the loop, this should be a break, not a continue. (The continue only skips the current loop iteration and goes directly to the next iteration).
  4. Christian Kuhn voted on patch set 1 CR -2 05/06/14, 09:56

  5. Christian Kuhn commented on patch set 1 05/06/14, 10:05

    If it is really required to have this (eg. because extensions in typo3conf/ext do broken stuff in ext_autoload.php), then we may add a environment variable that hints the autoloader to only include core stuff.
  6. Nicole Hummel abandoned the change 05/06/14, 10:22

    System has to be clean