Review main Merged

2992[BUGFIX] sys_action: Fix Record List page switching

Steffen Gebert CR +2 V +2 Normal +100 −2 updated 06/03/13, 20:49

Commit message

If a list-records-task lists more than 100 records, the singe table page turning
functionality is shown on top of the table. If you want to switch the page (or
enter a page number) nothing happens or you get elsewhere than you are supposed
to be.

This happens due to wrong link generation. The Listmodule has been refactored, but the
sys_actions Module stayed the same. Link generation was broken.

This patch fixes the issues with sys_actions and list link generation by subclassing
the localRecordList class and adopting the link generation to sys_actions needs.

Review

  • Code review CR +2
    • Christian Kuhn +2
    • Susi Moog +1
  • Verified V +2
    • Christian Kuhn +2
    • Susi Moog +1

Issues 1

Files 3

Review log 9

  1. Stefan Neufeind commented on patch set 1 08/21/11, 15:01

    wasn't able to reproduce this problem (before the patch, latest head). Created >100 sys_action-entries. I hope a long list in the top-right corner (dropdown-list) but that has no paging. And using the list-view I can see and browse all actions-items with and without the patch. Please give a hint how to test this.
  2. Susi Moog uploaded patch set 2 08/21/11, 15:01

  3. Susi Moog uploaded patch set 3 08/21/11, 15:01

  4. Susi Moog commented on patch set 3 08/21/11, 15:01

    Verified; Looks good to me, but someone else must approve Adapted the patch so it applies again. How to test: Create a taskcenter action that lists records. Choose a page with more than 100 records on it and select it in the action. Look at the list generated in the task center and try to change the page -> you get to the list module (if you have access) but you should stay in the task center.
  5. Mr. Jenkins commented on patch set 1 08/21/11, 15:01

  6. Mr. Jenkins commented on patch set 2 08/21/11, 15:01

  7. Mr. Jenkins commented on patch set 3 08/21/11, 15:01

  8. Christian Kuhn commented on patch set 3 V 0 08/21/11, 15:01

    by team member; Looks good to me, approved
  9. Christian Kuhn merged patch set 3 08/21/11, 15:01