29923[BUGFIX] Make object access work with ObjectStorage
Commit message
Review
-
Code review CR +2
- Georg Ringer +2
- Markus Klein +1
- Anja Leichsenring +1
- Tymoteusz Motylewski +1
- Fabien Udriot +1
-
Verified V +2
- Georg Ringer +2
- Anja Leichsenring +1
- Tymoteusz Motylewski +1
Issues 2
Files 2
Review log 22
-
Mr. Jenkins commented on patch set 1 05/07/14, 17:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16372/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16368/ : SUCCESS -
Helmut Hummel uploaded patch set 2 05/07/14, 17:55
-
Mr. Jenkins commented on patch set 2 05/07/14, 18:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16373/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16369/ : SUCCESS -
Philipp Gampe commented on patch set 2 CR +1 05/07/14, 19:59
Misses Releases: line. IMHO this should still go to 6.2 as an important API enhancement (and is trivial enough to assume no problems). Only if somebody counts on having the array access return NULL, this could lead to a problem. I cannot imagine this. -
Markus Klein commented on patch set 2 CR -1 05/07/14, 20:09
ObjectAccess.php:130SplObjectStorage does not implement toArray(), you can access the index directly. As ObjectStorage implements \ArrayAccess as well, I think the toArray() is superfluous in general. -
Helmut Hummel commented on patch set 2 05/07/14, 22:16
ObjectAccess.php:130Reply"SplObjectStorage does not implement toArray()" good point! "As ObjectStorage implements \ArrayAccess as well, I think the toArray() is superfluous in general" nope! see: http://forge.typo3.org/issues/37000 -
Helmut Hummel commented on patch set 2 05/07/14, 22:22
ObjectAccess.php:130Replyyou can check with return $subject[(int)$propertyName] or return $subject[$propertyName] and you will see the test fail... -
Helmut Hummel uploaded patch set 3 05/07/14, 22:23
-
Helmut Hummel commented on patch set 3 05/07/14, 22:24
back to my initial solution... -
Mr. Jenkins commented on patch set 3 05/07/14, 22:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16374/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16370/ : SUCCESS -
Markus Klein updated the commit message in patch set 3 05/07/14, 23:09
-
Markus Klein commented on patch set 2 05/07/14, 23:14
ObjectAccess.php:130Replyjust a note: it does not matter if you cast the index to int or not. PHP always tries to convert an index to integer internally. so for an array with indexes 0..3 you can use $arr['3'] and it will access 3. -
Mr. Jenkins commented on patch set 4 05/07/14, 23:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16375/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16371/ : SUCCESS -
Markus Klein uploaded patch set 5 05/08/14, 00:14
-
Markus Klein commented on patch set 5 CR +1 05/08/14, 00:19
Verified only with tests. -
Mr. Jenkins commented on patch set 5 05/08/14, 00:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16376/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16372/ : SUCCESS -
Anja Leichsenring voted on patch set 5 V +1 CR +1 06/01/14, 08:10
-
Fabien Udriot voted on patch set 5 CR +1 06/01/14, 12:08
-
Tymoteusz Motylewski commented on patch set 5 V +1 CR +1 06/01/14, 14:07
tested with modified template of ext:news, works fine -
Georg Ringer voted on patch set 5 V +2 CR +2 06/02/14, 10:41
-
Georg Ringer merged patch set 6 06/02/14, 10:41
-
Helmut Hummel commented on patch set 6 06/02/14, 16:29
Thanks everyone!