30005[TASK] Observe ext suggestions for ext loading order
Commit message
Review
-
Code review CR +2
- Xavier Perseguers +2
- Stefan Neufeind +1
- Thomas Maroschik +1
- Loek Hilgersom +1
- Fabien Udriot +1
-
Verified V +2
- Xavier Perseguers +2
- Loek Hilgersom +1
- Fabien Udriot +1
Issues 1
Files 2
Review log 19
-
Markus Klein commented on patch set 1 05/10/14, 23:58
Can be tested with its dependent patch. In order to test this, apply the patch and (un)install any extension. -
Markus Klein uploaded patch set 2 05/11/14, 00:04
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 05/11/14, 00:29
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16404/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16400/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16399/ : FAILURE -
Mr. Jenkins commented on patch set 2 CR -1 V -1 05/11/14, 01:17
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16406/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16402/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16401/ : FAILURE -
Markus Klein uploaded patch set 3 05/11/14, 21:32
-
Mr. Jenkins commented on patch set 3 CR -1 V -1 05/11/14, 22:15
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16410/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16406/ : FAILURE https://ci.typo3.org/job/typo3-v4-core-gerrit/16405/ : FAILURE -
Markus Klein uploaded patch set 4 05/11/14, 22:38
-
Markus Klein uploaded patch set 5 05/11/14, 22:44
-
Mr. Jenkins commented on patch set 4 05/11/14, 23:14
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16411/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16407/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16406/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/11/14, 23:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16413/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16409/ : SUCCESS https://ci.typo3.org/job/typo3-v4-core-gerrit/16408/ : SUCCESS -
Loek Hilgersom commented on patch set 5 V +1 CR +1 05/12/14, 19:35
Looks good and works as expected. Only concern I have is that it makes the system even more esoteric: you don't start looking for a 'suggest-feature' when need something like loading-order. But it does solve the problem. -
Thomas Maroschik voted on patch set 5 CR +1 05/13/14, 06:36
-
Stanislas Rolland commented on patch set 5 05/13/14, 13:09
Is it not strange to use the "suggest" option for this? Don't we need new options like "before" and/or "after"? -
Markus Klein commented on patch set 5 05/13/14, 13:18
As written in the ticket, it indeed is strange. But adding new keywords really gives us a headache for TER I guess. (but maybe I'm wrong here.) This topic is really urgent as of the rte settings not being displayed in user settings. -
Fabien Udriot voted on patch set 5 V +1 CR +1 05/14/14, 13:22
-
Stefan Neufeind voted on patch set 5 CR +1 05/20/14, 22:22
-
Xavier Perseguers voted on patch set 5 V +1 CR +1 06/10/14, 09:09
-
Xavier Perseguers commented on patch set 5 V +2 CR +2 06/10/14, 09:57
Enough votes -
Xavier Perseguers merged patch set 6 06/10/14, 09:57