Review main Merged

30005[TASK] Observe ext suggestions for ext loading order

Markus Klein CR +2 V +2 Normal +161 −0 updated 06/10/14, 09:57

Commit message

Let the DependencyResolver take the suggest-part of the composer.json
or ext_emconf.php files into account. This solves issues where it is
necessary to ensure a certain loading order of extensions without
having a real dependency between those.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Thomas Maroschik +1
    • Loek Hilgersom +1
    • Fabien Udriot +1
  • Verified V +2
    • Xavier Perseguers +2
    • Loek Hilgersom +1
    • Fabien Udriot +1

Issues 1

Files 2

Review log 19

  1. Markus Klein commented on patch set 1 05/10/14, 23:58

    Can be tested with its dependent patch. In order to test this, apply the patch and (un)install any extension.
  2. Markus Klein uploaded patch set 2 05/11/14, 00:04

  3. Mr. Jenkins commented on patch set 1 CR -1 V -1 05/11/14, 00:29

  4. Mr. Jenkins commented on patch set 2 CR -1 V -1 05/11/14, 01:17

  5. Markus Klein uploaded patch set 3 05/11/14, 21:32

  6. Mr. Jenkins commented on patch set 3 CR -1 V -1 05/11/14, 22:15

  7. Markus Klein uploaded patch set 4 05/11/14, 22:38

  8. Markus Klein uploaded patch set 5 05/11/14, 22:44

  9. Loek Hilgersom commented on patch set 5 V +1 CR +1 05/12/14, 19:35

    Looks good and works as expected. Only concern I have is that it makes the system even more esoteric: you don't start looking for a 'suggest-feature' when need something like loading-order. But it does solve the problem.
  10. Thomas Maroschik voted on patch set 5 CR +1 05/13/14, 06:36

  11. Stanislas Rolland commented on patch set 5 05/13/14, 13:09

    Is it not strange to use the "suggest" option for this? Don't we need new options like "before" and/or "after"?
  12. Markus Klein commented on patch set 5 05/13/14, 13:18

    As written in the ticket, it indeed is strange. But adding new keywords really gives us a headache for TER I guess. (but maybe I'm wrong here.) This topic is really urgent as of the rte settings not being displayed in user settings.
  13. Fabien Udriot voted on patch set 5 V +1 CR +1 05/14/14, 13:22

  14. Stefan Neufeind voted on patch set 5 CR +1 05/20/14, 22:22

  15. Xavier Perseguers voted on patch set 5 V +1 CR +1 06/10/14, 09:09

  16. Xavier Perseguers commented on patch set 5 V +2 CR +2 06/10/14, 09:57

    Enough votes
  17. Xavier Perseguers merged patch set 6 06/10/14, 09:57