Review main Merged

30015[TASK] Include suggest info into package metadata

Markus Klein CR +2 V +2 Normal +71 −0 updated 05/24/15, 22:50

Commit message

Enhance the Package metadata with information about suggested packages.
This information may be loaded from composer.json or ext_emconf.php.

Review

  • Code review CR +2
    • Xavier Perseguers +2
    • Stefan Neufeind +1
    • Thomas Maroschik +1
    • Fabien Udriot +1
  • Verified V +2
    • Xavier Perseguers +2
    • Fabien Udriot +1

Issues 1

Files 2

Review log 15

  1. Markus Klein uploaded patch set 2 05/11/14, 22:44

  2. Thomas Maroschik voted on patch set 2 CR +1 05/13/14, 06:35

  3. Fabien Udriot commented on patch set 2 V +1 CR -1 05/14/14, 13:18

    Package.php:189

    Why don't we do it right now? In general I prefer early failure (and therefore an exception) but it could be logged as a minimum measure.
  4. Markus Klein commented on patch set 2 05/14/14, 13:25

    Package.php:189 Reply

    Separate patch please. These 3 patches depending on each other are horrible enough already.
  5. Fabien Udriot commented on patch set 2 05/14/14, 13:39

    Package.php:189 Reply

    Ok, but could it be made a forth one on the top all? (just to avoid it stays as TODO forever)
  6. Markus Klein commented on patch set 2 05/14/14, 14:17

    Package.php:189 Reply

    sure, but please remove your -1
  7. Fabien Udriot voted on patch set 2 CR +1 05/14/14, 14:17

  8. Fabien Udriot commented on patch set 2 05/14/14, 14:19

    Package.php:189 Reply

    Done! Thanks for your work.
  9. Stefan Neufeind voted on patch set 2 CR +1 05/20/14, 22:20

  10. Xavier Perseguers voted on patch set 2 V +1 CR +1 06/10/14, 09:09

  11. Xavier Perseguers commented on patch set 2 V +2 CR +2 06/10/14, 09:57

    Enough votes
  12. Xavier Perseguers merged patch set 3 06/10/14, 09:57

  13. Markus Klein commented on patch set 3 05/24/15, 22:50

    Package.php:183

    bug here: must be 'suggests'