Review main Merged

30044[BUGFIX] Request update broken for select fields

Francois Suter CR +2 V +2 Easy +4 −1 updated 06/03/14, 14:32

Commit message

For select-type fields displayed as two side-by-side selectors
which are registered as "requestUpdate" fields, the form submission
happens before the value is copied to the left-hand selector.
The form is thus saved without value.

Full description in the bug report, which also contains a
test extension and steps to reproduce.

Review

  • Code review CR +2
    • Markus Klein +2
    • Tomas Norre Mikkelsen +1
    • Lorenz Ulrich +1
    • Fabien Udriot +1
    • Peter Foerger +1
  • Verified V +2
    • Markus Klein +2
    • Lorenz Ulrich +1
    • Fabien Udriot +1

Issues 1

Files 1

Review log 13

  1. Mr. Jenkins commented on patch set 1 05/13/14, 11:45

  2. Peter Foerger voted on patch set 1 CR +1 05/14/14, 08:42

  3. Fabien Udriot voted on patch set 1 CR +1 05/16/14, 07:16

  4. Francois Suter commented on patch set 1 05/16/14, 08:35

    Thanks for the reviews so far. Don't hesitate to test too, it's really easy with the example extension provided in the Forge issue.
  5. Fabien Udriot commented on patch set 1 V -1 05/18/14, 10:51

    The good: I can select one item form the select menu as described on the Forge ticket when patch is applied. The bad: I can select only *one* element. Selecting a second one, will no work. It has the same behaviour as the patch would have not be applied. Weirdness!
  6. Francois Suter commented on patch set 1 05/19/14, 06:45

    I had not tried that, but you're right. I guess it's a bug in the new FormEngine javascript. We'll see if I have the time to dig deeper.
  7. Francois Suter commented on patch set 1 05/21/14, 09:39

    I checked and it was a (stupid) mistake in my test extension. I have attached a new version to the Forge issue. Could you please test again?
  8. Fabien Udriot commented on patch set 1 V +1 05/27/14, 05:55

    Indeed, works better now.
  9. Tomas Norre Mikkelsen voted on patch set 1 CR +1 05/30/14, 06:56

  10. Lorenz Ulrich commented on patch set 1 V +1 CR +1 06/03/14, 12:21

    Works fine, thanks.
  11. Markus Klein voted on patch set 1 V +2 CR +2 06/03/14, 14:20

  12. Markus Klein merged patch set 2 06/03/14, 14:20

  13. Francois Suter commented on patch set 2 06/03/14, 14:32

    Thanks a lot, guys!