Review main Merged

30052[TASK] Add a function for clearing the rootline caches

Oliver Klee CR +2 V +2 Easy +21 −3 updated 06/28/14, 17:26

Commit message

The RootlineUtility uses two local caches and one additional cache from
the caching framework. If a unit test uses the RootlineUtility, it needs
a way of purging these caches so it does not change the environment.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 2

Review log 25

  1. Mr. Jenkins commented on patch set 1 05/13/14, 12:58

  2. Oliver Klee updated the commit message in patch set 1 05/13/14, 13:23

  3. Mr. Jenkins commented on patch set 2 05/13/14, 13:44

  4. Helmut Hummel commented on patch set 2 CR -1 05/13/14, 14:40

    RootlineUtility.php:181

    make method static please as these are static caches

    RootlineUtilityTest.php:49

    call parent here, please like in other test

    RootlineUtilityTest.php:50

    call statically, as suggested in original class
  5. Oliver Klee uploaded patch set 3 05/13/14, 15:13

  6. Oliver Klee uploaded patch set 4 05/13/14, 15:14

  7. Mr. Jenkins commented on patch set 3 05/13/14, 15:46

  8. Mr. Jenkins commented on patch set 4 05/13/14, 15:46

  9. Christian Kuhn commented on patch set 4 05/13/14, 19:07

    RootlineUtilityTest.php:46

    side question: should setUp and tearDown be public or protected? currently, we are mixing those, but more of them are public.
  10. Oliver Klee commented on patch set 4 05/13/14, 19:09

    RootlineUtilityTest.php:46 Reply

    They should be protected: They are protected in the original base class, and there is no need to make them public (unlike the test functions, which need to be public AFAIK).
  11. Tobias Liebig voted on patch set 4 V +1 CR +1 05/23/14, 08:37

  12. Krzysztof Adamczyk voted on patch set 4 CR +1 06/11/14, 07:58

  13. Oliver Klee updated the commit message in patch set 4 06/19/14, 15:19

  14. Mr. Jenkins commented on patch set 5 06/19/14, 15:35

  15. Markus Klein commented on patch set 5 06/22/14, 01:14

    RootlineUtilityTest.php:47

    shouldn't we call parent::setUp() first??
  16. Oliver Klee commented on patch set 5 06/22/14, 09:22

    RootlineUtilityTest.php:47 Reply

    Not in this case as the parent setUp is completely empty.
  17. Oliver Klee uploaded patch set 6 06/22/14, 10:07

  18. Oliver Klee commented on patch set 6 06/22/14, 10:08

    Drop the call to clear the cache (from the caching framework) because setting the cache BE to a NULL backend would be cleaner.
  19. Mr. Jenkins commented on patch set 6 06/22/14, 10:22

  20. Marcus Krause voted on patch set 6 V +1 CR +1 06/28/14, 16:58

  21. Markus Klein updated the commit message in patch set 6 06/28/14, 17:09

  22. Markus Klein commented on patch set 7 V +2 CR +2 06/28/14, 17:12

    Votes of Marcus still valid as I just updated the commit message.
  23. Markus Klein merged patch set 8 06/28/14, 17:12

  24. Markus Klein commented on patch set 8 06/28/14, 17:12

    Cherry Picked This patchset was cherry picked to change: Ia9878b808acfa03f018086829f90b84d4c5e8512
  25. Mr. Jenkins commented on patch set 7 06/28/14, 17:26