30052[TASK] Add a function for clearing the rootline caches
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 2
Review log 25
-
Mr. Jenkins commented on patch set 1 05/13/14, 12:58
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16425/ : SUCCESS -
Oliver Klee updated the commit message in patch set 1 05/13/14, 13:23
-
Mr. Jenkins commented on patch set 2 05/13/14, 13:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16426/ : SUCCESS -
Helmut Hummel commented on patch set 2 CR -1 05/13/14, 14:40
RootlineUtility.php:181make method static please as these are static cachesRootlineUtilityTest.php:49call parent here, please like in other testRootlineUtilityTest.php:50call statically, as suggested in original class -
Oliver Klee uploaded patch set 3 05/13/14, 15:13
-
Oliver Klee uploaded patch set 4 05/13/14, 15:14
-
Mr. Jenkins commented on patch set 3 05/13/14, 15:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16431/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/13/14, 15:46
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16432/ : SUCCESS -
Christian Kuhn commented on patch set 4 05/13/14, 19:07
RootlineUtilityTest.php:46side question: should setUp and tearDown be public or protected? currently, we are mixing those, but more of them are public. -
Oliver Klee commented on patch set 4 05/13/14, 19:09
RootlineUtilityTest.php:46ReplyThey should be protected: They are protected in the original base class, and there is no need to make them public (unlike the test functions, which need to be public AFAIK). -
Tobias Liebig voted on patch set 4 V +1 CR +1 05/23/14, 08:37
-
Krzysztof Adamczyk voted on patch set 4 CR +1 06/11/14, 07:58
-
Oliver Klee updated the commit message in patch set 4 06/19/14, 15:19
-
Mr. Jenkins commented on patch set 5 06/19/14, 15:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16824/ : SUCCESS -
Markus Klein commented on patch set 5 06/22/14, 01:14
RootlineUtilityTest.php:47shouldn't we call parent::setUp() first?? -
Oliver Klee commented on patch set 5 06/22/14, 09:22
RootlineUtilityTest.php:47ReplyNot in this case as the parent setUp is completely empty. -
Oliver Klee uploaded patch set 6 06/22/14, 10:07
-
Oliver Klee commented on patch set 6 06/22/14, 10:08
Drop the call to clear the cache (from the caching framework) because setting the cache BE to a NULL backend would be cleaner. -
Mr. Jenkins commented on patch set 6 06/22/14, 10:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16992/ : SUCCESS -
Marcus Krause voted on patch set 6 V +1 CR +1 06/28/14, 16:58
-
Markus Klein updated the commit message in patch set 6 06/28/14, 17:09
-
Markus Klein commented on patch set 7 V +2 CR +2 06/28/14, 17:12
Votes of Marcus still valid as I just updated the commit message. -
Markus Klein merged patch set 8 06/28/14, 17:12
-
Markus Klein commented on patch set 8 06/28/14, 17:12
Cherry Picked This patchset was cherry picked to change: Ia9878b808acfa03f018086829f90b84d4c5e8512 -
Mr. Jenkins commented on patch set 7 06/28/14, 17:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17082/ : SUCCESS