Review TYPO3_6-1 Abandoned

30056[TASK] Add a function for clearing the rootline caches

Oliver Klee CR 0 V 0 Easy +22 −2 updated 07/18/14, 14:21

Commit message

The RootlineUtitility uses two local caches and one additional cache from
the caching framework. If a unit test uses the RootlineUtitility, it needs
a way of purging these caches so it does not change the environment.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 2

Review log 7

  1. Oliver Klee uploaded patch set 2 05/13/14, 15:13

  2. Tobias Liebig voted on patch set 2 V +1 CR +1 05/23/14, 08:38

  3. Oliver Klee updated the commit message in patch set 2 06/19/14, 15:19

  4. Markus Klein commented on patch set 3 CR -2 06/22/14, 01:10

    This is a backport of a not yet merged master-patch and the change-id does not match. Please abandon this patch and create the backports after the master patch was merged and remember to keep the change-id for the backports. thanks.
  5. Oliver Klee commented on patch set 3 06/22/14, 09:21

    The patch for 6.1 is different from 6.2/master because 6.2 introduced additional caches. Should I still abandon this patch?
  6. Markus Klein commented on patch set 3 06/22/14, 10:22

    Oh, sorry Oli, I missed that missing lines. Then of course keep it. I'll still keep my -2 until master is merged. Thanks.
  7. Oliver Klee abandoned the change 07/18/14, 14:21

    This already has been backported.