Review main Abandoned

30091[BUGFIX] Remove cookie for workspace preview if invalid

Georg Ringer CR 0 V 0 Easy +26 −3 updated 07/05/17, 18:04

Commit message

If the link is expired but the cookie is still there, an exception
is presented and there is only one chance to get the site working again
which is removing the cookie manually.

As this is not really user friendly, the cookie must be removed
automatically.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 3235

Show 10 earlier messages
  1. Georg Ringer commented on patch set 1 V +1 CR +1 05/14/14, 03:04

    patch is not from me, therefore voting is valid
  2. Mr. Jenkins commented on patch set 1 05/14/14, 03:17

  3. Wouter Wolters commented on patch set 1 05/14/14, 06:26

    Can you set the correct author then?
    missing #
  4. Georg Ringer uploaded patch set 2 05/15/14, 06:38

  5. Georg Ringer voted on patch set 2 V +1 CR +1 05/15/14, 06:39

  6. Mr. Jenkins commented on patch set 2 05/15/14, 06:52

  7. Oliver Klee voted on patch set 2 CR +1 05/15/14, 07:57

  8. Oliver Hader commented on patch set 2 CR -1 05/15/14, 10:45

    Working on it...

    PreviewHook.php:223

    $this->previewKey

    PreviewHook.php:224

    That does not remove a cookie...
  9. Oliver Hader uploaded patch set 3 05/15/14, 10:47

  10. Mr. Jenkins commented on patch set 3 05/15/14, 11:16

  1. Markus Klein voted on patch set 3 CR +1 05/15/14, 12:42

  2. Lorenz Ulrich commented on patch set 3 V +1 CR +1 05/23/14, 20:35

    Works fine, thanks!
  3. Oliver Klee commented on patch set 3 CR +1 05/24/14, 10:05

    PreviewHook.php:227

    As throwing an exception exits the function, we can simplify this to: if (!isset) { throw } $this->setCookie

    PreviewHook.php:292

    integer -> int
  4. Lorenz Ulrich commented on patch set 3 V -1 CR 0 06/10/14, 09:07

    I just tested this again and came across the following: - The workspace preview session is no longer valid: The cookie is removed and the live version is displayed - Once I refresh again, the same exception is thrown: "1294585192: ADMCMD command could not be executed! (No keyword configuration found)" because their was neither a valid preview session nor a cookie to remove. I thought that the correct behaviour would be to display the live version of a site if the Workspace link is no longer present?
  5. Mathias Schreiber wrote 12/17/14, 14:34

    Topic set to EXT: version
  6. Markus Klein wrote 03/30/15, 23:29

    Removed the following approvals: * Code-Review+1 by Markus Klein <klein.t3@reelworx.at>
  7. Benni Mack commented on patch set 3 07/17/15, 13:37

    Georg, can you please update this patch?
  8. Oliver Hader uploaded patch set 4 10/09/15, 12:55

  9. Nicole Hummel commented on patch set 4 CR -1 11/03/15, 20:43

    PreviewHook.php:281

    int

    PreviewHook.php:282

    we do not add @return void
  10. Oliver Hader commented on patch set 4 CR -1 V +1 11/25/15, 21:08

    PreviewHook.php:286

    What about HTTP-only and secure in this regard? Those settings can be defined in the install tool.
  11. Benni Mack commented on patch set 4 CR -1 11/29/15, 21:32

    6.2 only? but put in master?
  12. Andreas Kienast uploaded patch set 5 03/11/16, 11:27

  13. Claus Due commented on patch set 5 CR +1 09/20/16, 12:49

    Logic looks sound.
  14. Christian Weiske commented on patch set 5 CR +1 V +1 10/17/16, 12:52

    Works fine on TYPO3 7.6.10
  15. Anja Leichsenring uploaded patch set 6 12/04/16, 11:54

  16. Anja Leichsenring commented on patch set 6 12/04/16, 11:55

    rebased
  17. Anja Leichsenring commented on patch set 6 CR -1 12/04/16, 11:57

    needs some adjustment, as the cookieService was introduced some patches before, that takes care of centralized handling of cookies. Will take care asap.
  18. TYPO3com voted on patch set 6 V -1 12/04/16, 12:04 Completed build in 09m 33s on Sun, 4 Dec, 01:04 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5500

  19. Georg Ringer uploaded patch set 7 01/26/17, 19:11

  20. TYPO3com voted on patch set 7 V +1 01/26/17, 19:17 Completed build in 05m 57s on Thu, 26 Jan, 08:17 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7077

  21. Anja Leichsenring commented on patch set 7 01/29/17, 19:48

    please consider https://review.typo3.org/#/c/50808/ first, then align both changes.
  22. Stefan Neufeind voted on patch set 7 CR +1 01/29/17, 20:12

  23. Georg Ringer uploaded patch set 8 02/06/17, 10:10

  24. TYPO3com voted on patch set 8 V +1 02/06/17, 10:16 Completed build in 05m 41s on Mon, 6 Feb, 11:16 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7555

  25. Georg Ringer abandoned the change 07/05/17, 18:04