30091[BUGFIX] Remove cookie for workspace preview if invalid
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 1
Review log 3235
Show 10 earlier messages
-
Georg Ringer commented on patch set 1 V +1 CR +1 05/14/14, 03:04
patch is not from me, therefore voting is valid -
Mr. Jenkins commented on patch set 1 05/14/14, 03:17
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16434/ : SUCCESS -
Wouter Wolters commented on patch set 1 05/14/14, 06:26
Can you set the correct author then?missing # -
Georg Ringer uploaded patch set 2 05/15/14, 06:38
-
Georg Ringer voted on patch set 2 V +1 CR +1 05/15/14, 06:39
-
Mr. Jenkins commented on patch set 2 05/15/14, 06:52
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16459/ : SUCCESS -
Oliver Klee voted on patch set 2 CR +1 05/15/14, 07:57
-
Oliver Hader commented on patch set 2 CR -1 05/15/14, 10:45
Working on it...PreviewHook.php:223$this->previewKeyPreviewHook.php:224That does not remove a cookie... -
Oliver Hader uploaded patch set 3 05/15/14, 10:47
-
Mr. Jenkins commented on patch set 3 05/15/14, 11:16
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16460/ : SUCCESS
-
Markus Klein voted on patch set 3 CR +1 05/15/14, 12:42
-
Lorenz Ulrich commented on patch set 3 V +1 CR +1 05/23/14, 20:35
Works fine, thanks! -
Oliver Klee commented on patch set 3 CR +1 05/24/14, 10:05
PreviewHook.php:227As throwing an exception exits the function, we can simplify this to: if (!isset) { throw } $this->setCookiePreviewHook.php:292integer -> int -
Lorenz Ulrich commented on patch set 3 V -1 CR 0 06/10/14, 09:07
I just tested this again and came across the following: - The workspace preview session is no longer valid: The cookie is removed and the live version is displayed - Once I refresh again, the same exception is thrown: "1294585192: ADMCMD command could not be executed! (No keyword configuration found)" because their was neither a valid preview session nor a cookie to remove. I thought that the correct behaviour would be to display the live version of a site if the Workspace link is no longer present? -
Mathias Schreiber wrote 12/17/14, 14:34
Topic set to EXT: version -
Markus Klein wrote 03/30/15, 23:29
Removed the following approvals: * Code-Review+1 by Markus Klein <klein.t3@reelworx.at> -
Benni Mack commented on patch set 3 07/17/15, 13:37
Georg, can you please update this patch? -
Oliver Hader uploaded patch set 4 10/09/15, 12:55
-
Nicole Hummel commented on patch set 4 CR -1 11/03/15, 20:43
PreviewHook.php:281intPreviewHook.php:282we do not add @return void -
Oliver Hader commented on patch set 4 CR -1 V +1 11/25/15, 21:08
PreviewHook.php:286What about HTTP-only and secure in this regard? Those settings can be defined in the install tool. -
Benni Mack commented on patch set 4 CR -1 11/29/15, 21:32
6.2 only? but put in master? -
Andreas Kienast uploaded patch set 5 03/11/16, 11:27
-
Claus Due commented on patch set 5 CR +1 09/20/16, 12:49
Logic looks sound. -
Christian Weiske commented on patch set 5 CR +1 V +1 10/17/16, 12:52
Works fine on TYPO3 7.6.10 -
Anja Leichsenring uploaded patch set 6 12/04/16, 11:54
-
Anja Leichsenring commented on patch set 6 12/04/16, 11:55
rebased -
Anja Leichsenring commented on patch set 6 CR -1 12/04/16, 11:57
needs some adjustment, as the cookieService was introduced some patches before, that takes care of centralized handling of cookies. Will take care asap. -
TYPO3com voted on patch set 6 V -1 12/04/16, 12:04 Completed build in 09m 33s on Sun, 4 Dec, 01:04 PM Test Summary: 54322 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-5500
-
Georg Ringer uploaded patch set 7 01/26/17, 19:11
-
TYPO3com voted on patch set 7 V +1 01/26/17, 19:17 Completed build in 05m 57s on Thu, 26 Jan, 08:17 PM Test Summary: 55595 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7077
-
Anja Leichsenring commented on patch set 7 01/29/17, 19:48
please consider https://review.typo3.org/#/c/50808/ first, then align both changes. -
Stefan Neufeind voted on patch set 7 CR +1 01/29/17, 20:12
-
Georg Ringer uploaded patch set 8 02/06/17, 10:10
-
TYPO3com voted on patch set 8 V +1 02/06/17, 10:16 Completed build in 05m 41s on Mon, 6 Feb, 11:16 AM Test Summary: 55955 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-7555
-
Georg Ringer abandoned the change 07/05/17, 18:04