Review main Merged

30098[BUGFIX] Remove non accessible pages from browse menu

Kay Strobach CR +2 V +2 Easy +17 −4 updated 10/07/14, 21:34

Commit message

This patch enables the browse menu to skip inaccessible items
for prev and next links.

It makes use of the filterMenuPages method, which is already
applied to any kind of menu. Since it has not been applied
to the sections of the browse menu type, which are actually
menus themselves, inaccessible pages made browsing unusable.

This applies to missing translations as well.

Review

  • Code review CR +2
    • Markus Klein +2
    • Jo Hasenau +1
    • Marcin Sągol +1
    • Stefan Neufeind +1
  • Verified V +2
    • Markus Klein +2
    • Jo Hasenau +1

Issues 1

Files 1

Review log 47

Show 22 earlier messages
  1. Mr. Jenkins commented on patch set 1 CR -1 V -1 05/14/14, 07:44

  2. Kay Strobach updated the commit message in patch set 1 05/14/14, 08:17

  3. Mr. Jenkins commented on patch set 2 05/14/14, 08:44

  4. Jo Hasenau commented on patch set 2 CR -1 05/14/14, 10:16

    See comment

    AbstractMenuContentObject.php:926

    Should be removeInaccessiblePages and the variable name should be accessiblePages
  5. Kay Strobach uploaded patch set 3 05/14/14, 10:47

  6. Wouter Wolters commented on patch set 3 CR -1 05/14/14, 10:50

    AbstractMenuContentObject.php:923

    Missing description

    AbstractMenuContentObject.php:926

    typehint array?

    AbstractMenuContentObject.php:928

    space after foreach missing

    AbstractMenuContentObject.php:929

    space after if missing please use the constant for the doktype
  7. Kay Strobach uploaded patch set 4 05/14/14, 10:54

  8. Jo Hasenau updated the commit message in patch set 4 05/14/14, 11:01

  9. Jo Hasenau commented on patch set 5 05/14/14, 11:01

    See comment
  10. Jo Hasenau commented on patch set 4 05/14/14, 11:02

    AbstractMenuContentObject.php:924

    Don't want to be nitpicking, but the comment should be "accessible" as well ;-)
  11. Kay Strobach uploaded patch set 6 05/14/14, 11:04

  12. Jo Hasenau voted on patch set 6 V +1 CR +1 05/14/14, 11:09

  13. Mr. Jenkins commented on patch set 3 05/14/14, 11:15

  14. Mr. Jenkins commented on patch set 4 05/14/14, 11:15

  15. Mr. Jenkins commented on patch set 5 05/14/14, 11:45

  16. Mr. Jenkins commented on patch set 6 05/14/14, 11:45

  17. Peter Foerger voted on patch set 6 CR +1 05/15/14, 11:53

  18. Fabien Udriot updated the commit message in patch set 6 05/15/14, 13:25

  19. Fabien Udriot commented on patch set 7 05/15/14, 13:28

    AbstractMenuContentObject.php:924

    Upper case "Gets" to be consistent. Sorry for the nitpicking....
  20. Mr. Jenkins commented on patch set 7 05/15/14, 13:47

  21. Jo Hasenau voted on patch set 7 V +1 CR +1 05/15/14, 18:36

  22. Oliver Hader commented on patch set 7 05/18/14, 13:58

    I'd opt to have some functional tests for these special scenario things - because by simple reading this issue I can hardly imagine what the problem is and what the expected behaviour should be... I'm going to have a look into the issue next week.
    Please describe it a bit better... What are these "problems"?
    Is this the bug or the solution?
  1. Oliver Hader commented on patch set 7 05/18/14, 14:00

    6.2 is not branched of yet... I'm not sure whether 4.5 should be considered as well... It depends on the impact...
  2. Kay Strobach updated the commit message in patch set 7 05/20/14, 12:16

  3. Oliver Klee commented on patch set 8 05/20/14, 14:28

    AbstractMenuContentObject.php:929

    type hinting is missing
  4. Jo Hasenau commented on patch set 8 V -1 CR -1 05/21/14, 10:48

    The filterMenuPages method uses a banUidArray, which should be filled with the correct data instead of using an empty array().
  5. Jo Hasenau uploaded patch set 9 05/21/14, 10:56

  6. Mr. Jenkins commented on patch set 9 05/21/14, 11:13

  7. Fabien Udriot commented on patch set 9 05/24/14, 11:42

    @Oliver ah, interesting to see how it can be tested with feature tests.
  8. Kay Strobach commented on patch set 9 06/16/14, 08:54

    any news on that? i mean i just used some already existing core functions to fix some stuff ... hate fixes hanging around in gerrit for ever ...
  9. Markus Klein commented on patch set 9 06/22/14, 01:07

    Releases: 6.3, 6.2, 6.1, 4.7, 4.5 or Releases: 6.3, 6.2

    AbstractMenuContentObject.php:924

    ucfirst()

    AbstractMenuContentObject.php:929

    array typehint missing for parameter

    AbstractMenuContentObject.php:936

    simpler: return array_filter($pages, function($page) { return $this->filterMenuPages($page, $this->getBannedUids(), $page['doktype'] === PageRepository::DOKTYPE_SPACE R); });
  10. Markus Klein uploaded patch set 10 07/06/14, 22:33

  11. Mr. Jenkins commented on patch set 10 07/06/14, 22:48

  12. Jo Hasenau voted on patch set 10 V +1 CR +1 07/08/14, 08:09

  13. Marcin Sągol voted on patch set 10 CR +1 07/08/14, 10:27

  14. Stefan Neufeind voted on patch set 10 CR +1 07/18/14, 22:49

  15. Markus Klein voted on patch set 10 CR +2 V +2 08/23/14, 14:54

  16. Markus Klein merged patch set 10 08/23/14, 14:54

  17. Markus Klein commented on patch set 11 08/23/14, 14:54

    Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit fe0234c828cd599d570e48aba299200fd2c35450
  18. Benni Mack commented on patch set 11 09/09/14, 14:33

    Regression --- This patch never works: $page['doktype'] === PageRepository::DOKTYPE_SPACER as the variable is always a string coming from the DB.
  19. Francois Suter commented on patch set 11 09/18/14, 12:17

    This patch triggers the following error for me: "PHP Fatal error: Using $this when not in object context in /usr/local/src/typo3/TYPO3_6-2/typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php on line 918" My frontend is broken. Any idea what's up?
  20. Wouter Wolters commented on patch set 11 09/18/14, 13:28

    Francois, which PHP version are you using? I guess it is PHP 5.3 and this function doesn't work on 5.3..
  21. Francois Suter commented on patch set 11 09/18/14, 13:48

    I see. But then it was backported as is on 6.2, which is supposed to be compatible with PHP 5.3. It needs to be reverted for 6.2 and adapted.
  22. Markus Klein commented on patch set 11 09/18/14, 13:52

    You're right. But I wouldn't revert it. A simple followup should suffice
  23. Markus Klein commented on patch set 11 09/18/14, 13:56

    AbstractMenuContentObject.php:918

    Either add a "use ($this)" or move this call outside the closure and add a "use ($bannedUids)" Will talk to Francois to test this.
  24. Markus Klein commented on patch set 11 09/18/14, 13:58

  25. Markus Klein commented on patch set 11 10/07/14, 21:34

    Maybe a regression to this: https://forge.typo3.org/issues/62088