30098[BUGFIX] Remove non accessible pages from browse menu
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Jo Hasenau +1
- Marcin Sągol +1
- Stefan Neufeind +1
-
Verified V +2
- Markus Klein +2
- Jo Hasenau +1
Issues 1
Files 1
Review log 47
Show 22 earlier messages
-
Mr. Jenkins commented on patch set 1 CR -1 V -1 05/14/14, 07:44
Build Failed https://ci.typo3.org/job/typo3-v4-core-gerrit/16436/ : FAILURE -
Kay Strobach updated the commit message in patch set 1 05/14/14, 08:17
-
Mr. Jenkins commented on patch set 2 05/14/14, 08:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16437/ : SUCCESS -
Jo Hasenau commented on patch set 2 CR -1 05/14/14, 10:16
See commentAbstractMenuContentObject.php:926Should be removeInaccessiblePages and the variable name should be accessiblePages -
Kay Strobach uploaded patch set 3 05/14/14, 10:47
-
Wouter Wolters commented on patch set 3 CR -1 05/14/14, 10:50
AbstractMenuContentObject.php:923Missing descriptionAbstractMenuContentObject.php:926typehint array?AbstractMenuContentObject.php:928space after foreach missingAbstractMenuContentObject.php:929space after if missing please use the constant for the doktype -
Kay Strobach uploaded patch set 4 05/14/14, 10:54
-
Jo Hasenau updated the commit message in patch set 4 05/14/14, 11:01
-
Jo Hasenau commented on patch set 5 05/14/14, 11:01
See comment -
Jo Hasenau commented on patch set 4 05/14/14, 11:02
AbstractMenuContentObject.php:924Don't want to be nitpicking, but the comment should be "accessible" as well ;-) -
Kay Strobach uploaded patch set 6 05/14/14, 11:04
-
Jo Hasenau voted on patch set 6 V +1 CR +1 05/14/14, 11:09
-
Mr. Jenkins commented on patch set 3 05/14/14, 11:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16443/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/14/14, 11:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16444/ : SUCCESS -
Mr. Jenkins commented on patch set 5 05/14/14, 11:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16445/ : SUCCESS -
Mr. Jenkins commented on patch set 6 05/14/14, 11:45
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16446/ : SUCCESS -
Peter Foerger voted on patch set 6 CR +1 05/15/14, 11:53
-
Fabien Udriot updated the commit message in patch set 6 05/15/14, 13:25
-
Fabien Udriot commented on patch set 7 05/15/14, 13:28
AbstractMenuContentObject.php:924Upper case "Gets" to be consistent. Sorry for the nitpicking.... -
Mr. Jenkins commented on patch set 7 05/15/14, 13:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16463/ : SUCCESS -
Jo Hasenau voted on patch set 7 V +1 CR +1 05/15/14, 18:36
-
Oliver Hader commented on patch set 7 05/18/14, 13:58
I'd opt to have some functional tests for these special scenario things - because by simple reading this issue I can hardly imagine what the problem is and what the expected behaviour should be... I'm going to have a look into the issue next week.Please describe it a bit better... What are these "problems"?Is this the bug or the solution?
-
Oliver Hader commented on patch set 7 05/18/14, 14:00
6.2 is not branched of yet... I'm not sure whether 4.5 should be considered as well... It depends on the impact... -
Kay Strobach updated the commit message in patch set 7 05/20/14, 12:16
-
Oliver Klee commented on patch set 8 05/20/14, 14:28
AbstractMenuContentObject.php:929type hinting is missing -
Jo Hasenau commented on patch set 8 V -1 CR -1 05/21/14, 10:48
The filterMenuPages method uses a banUidArray, which should be filled with the correct data instead of using an empty array(). -
Jo Hasenau uploaded patch set 9 05/21/14, 10:56
-
Mr. Jenkins commented on patch set 9 05/21/14, 11:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16493/ : SUCCESS -
Fabien Udriot commented on patch set 9 05/24/14, 11:42
@Oliver ah, interesting to see how it can be tested with feature tests. -
Kay Strobach commented on patch set 9 06/16/14, 08:54
any news on that? i mean i just used some already existing core functions to fix some stuff ... hate fixes hanging around in gerrit for ever ... -
Markus Klein commented on patch set 9 06/22/14, 01:07
Releases: 6.3, 6.2, 6.1, 4.7, 4.5 or Releases: 6.3, 6.2AbstractMenuContentObject.php:924ucfirst()AbstractMenuContentObject.php:929array typehint missing for parameterAbstractMenuContentObject.php:936simpler: return array_filter($pages, function($page) { return $this->filterMenuPages($page, $this->getBannedUids(), $page['doktype'] === PageRepository::DOKTYPE_SPACE R); }); -
Markus Klein uploaded patch set 10 07/06/14, 22:33
-
Mr. Jenkins commented on patch set 10 07/06/14, 22:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/17263/ : SUCCESS -
Jo Hasenau voted on patch set 10 V +1 CR +1 07/08/14, 08:09
-
Marcin Sągol voted on patch set 10 CR +1 07/08/14, 10:27
-
Stefan Neufeind voted on patch set 10 CR +1 07/18/14, 22:49
-
Markus Klein voted on patch set 10 CR +2 V +2 08/23/14, 14:54
-
Markus Klein merged patch set 10 08/23/14, 14:54
-
Markus Klein commented on patch set 11 08/23/14, 14:54
Cherry Picked This patchset was cherry picked to branch TYPO3_6-2 as commit fe0234c828cd599d570e48aba299200fd2c35450 -
Benni Mack commented on patch set 11 09/09/14, 14:33
Regression --- This patch never works: $page['doktype'] === PageRepository::DOKTYPE_SPACER as the variable is always a string coming from the DB. -
Francois Suter commented on patch set 11 09/18/14, 12:17
This patch triggers the following error for me: "PHP Fatal error: Using $this when not in object context in /usr/local/src/typo3/TYPO3_6-2/typo3/sysext/frontend/Classes/ContentObject/Menu/AbstractMenuContentObject.php on line 918" My frontend is broken. Any idea what's up? -
Wouter Wolters commented on patch set 11 09/18/14, 13:28
Francois, which PHP version are you using? I guess it is PHP 5.3 and this function doesn't work on 5.3.. -
Francois Suter commented on patch set 11 09/18/14, 13:48
I see. But then it was backported as is on 6.2, which is supposed to be compatible with PHP 5.3. It needs to be reverted for 6.2 and adapted. -
Markus Klein commented on patch set 11 09/18/14, 13:52
You're right. But I wouldn't revert it. A simple followup should suffice -
Markus Klein commented on patch set 11 09/18/14, 13:56
AbstractMenuContentObject.php:918Either add a "use ($this)" or move this call outside the closure and add a "use ($bannedUids)" Will talk to Francois to test this. -
Markus Klein commented on patch set 11 09/18/14, 13:58
Regression ticket: https://forge.typo3.org/issues/61721 -
Markus Klein commented on patch set 11 10/07/14, 21:34
Maybe a regression to this: https://forge.typo3.org/issues/62088