Review main Merged

30118[BUGFIX] Admin panel text selection

Goran Medakovic CR +2 V +2 Easy +6 −4 updated 05/29/14, 14:19

Commit message

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Markus Klein +1
    • Tymoteusz Motylewski +1
  • Verified V +2
    • Wouter Wolters +2
    • Markus Klein +1

Files 1

Review log 14

  1. Mr. Jenkins commented on patch set 1 05/14/14, 17:13

  2. Markus Klein updated the commit message in patch set 1 05/14/14, 20:53

  3. Markus Klein uploaded patch set 3 05/14/14, 21:00

  4. Markus Klein commented on patch set 3 05/14/14, 21:11

    Played around with your solution. had some glitches here and there. Tried prevenDefault() now and it seems to work better
  5. Mr. Jenkins commented on patch set 2 05/14/14, 21:15

  6. Mr. Jenkins commented on patch set 3 05/14/14, 21:15

  7. Goran Medakovic commented on patch set 3 05/15/14, 14:02

    actually "return false" should work for all browsers / platforms while prevenDefault is implemented only in modern browsers. Best solution would be to have both in the event handler to have all cases handled.
  8. Markus Klein commented on patch set 3 05/15/14, 14:19

    Good
  9. Markus Klein uploaded patch set 4 05/15/14, 15:02

  10. Markus Klein voted on patch set 4 V +1 CR +1 05/15/14, 15:02

  11. Mr. Jenkins commented on patch set 4 05/15/14, 15:18

  12. Tymoteusz Motylewski voted on patch set 4 CR +1 05/22/14, 14:45

  13. Wouter Wolters voted on patch set 4 V +2 CR +2 05/29/14, 14:19

  14. Wouter Wolters merged patch set 5 05/29/14, 14:19