30118[BUGFIX] Admin panel text selection
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Markus Klein +1
- Tymoteusz Motylewski +1
-
Verified V +2
- Wouter Wolters +2
- Markus Klein +1
Files 1
Review log 14
-
Mr. Jenkins commented on patch set 1 05/14/14, 17:13
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16456/ : SUCCESS -
Markus Klein updated the commit message in patch set 1 05/14/14, 20:53
-
Markus Klein uploaded patch set 3 05/14/14, 21:00
-
Markus Klein commented on patch set 3 05/14/14, 21:11
Played around with your solution. had some glitches here and there. Tried prevenDefault() now and it seems to work better -
Mr. Jenkins commented on patch set 2 05/14/14, 21:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16457/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/14/14, 21:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16458/ : SUCCESS -
Goran Medakovic commented on patch set 3 05/15/14, 14:02
actually "return false" should work for all browsers / platforms while prevenDefault is implemented only in modern browsers. Best solution would be to have both in the event handler to have all cases handled. -
Markus Klein commented on patch set 3 05/15/14, 14:19
Good -
Markus Klein uploaded patch set 4 05/15/14, 15:02
-
Markus Klein voted on patch set 4 V +1 CR +1 05/15/14, 15:02
-
Mr. Jenkins commented on patch set 4 05/15/14, 15:18
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16464/ : SUCCESS -
Tymoteusz Motylewski voted on patch set 4 CR +1 05/22/14, 14:45
-
Wouter Wolters voted on patch set 4 V +2 CR +2 05/29/14, 14:19
-
Wouter Wolters merged patch set 5 05/29/14, 14:19