Review main Merged

3016[BUGFIX] Re-Introduce removed API method and mark it deprecated

Helmut Hummel CR +2 V +2 Easy +31 −0 updated 06/03/13, 20:49

Commit message

After the refactoring of the form protection framework the API method persitTokens()
has been removed.

To not break existing extensions, re-introduce this method and
mark it as deprecated.

Review

  • Code review CR +2
    • Dmitry Dulepov +2
    • Stefan Neufeind +1
    • Oliver Klee +1
  • Verified V +2
    • Dmitry Dulepov +2

Issues 1

Files 3

Review log 8

  1. Dmitry Dulepov commented on patch set 1 07/04/11, 14:22

    Looks good to me, approved
  2. Dmitry Dulepov commented on patch set 1 V 0 07/04/11, 14:22

    by team member
  3. Stefan Neufeind commented on patch set 1 07/04/11, 14:22

    I would prefer that you didn't submit this See 3017: https://review.typo3.org/#change,3017 imho we should also re-implement the functionality, not just add the API and log-entries
  4. Stefan Neufeind commented on patch set 1 07/04/11, 14:22

    Looks good to me, but someone else must approve Hmm, couldn't judge about the background of this. I'm not that much "inside the topic". Just saw it was different before and Helmut said he re-introduced the function. Trusting you then that this makes sense :-) Rest looks okay.
  5. Oliver Klee commented on patch set 1 07/04/11, 14:22

    Looks good to me, but someone else must approve As there now are no individual tokens to persist, it makes sense to me to have the function a no-op (the way the patch does it).
  6. Philipp Gampe commented on patch set 1 07/04/11, 14:22

    Either keep this and abandon #3017 or abandon this one.
  7. Mr. Jenkins commented on patch set 1 07/04/11, 14:22

  8. Dmitry Dulepov merged patch set 1 07/04/11, 14:22