3017[BUGFIX] Re-Introduce removed API method and mark it deprecated
Commit message
Review
-
Code review CR -1
- Dmitry Dulepov +2
- Stefan Neufeind -1
- Oliver Klee +1
- Philipp Gampe +1
-
Verified V +2
- Dmitry Dulepov +2
- Philipp Gampe +1
Issues 1
Files 3
Review log 12
-
Dmitry Dulepov commented on patch set 2 07/05/11, 09:35
Looks good to me, approved Logic is now different, so these functions should not work. We are adding them back as stubs only because we cannot remove functions so early. -
Stefan Neufeind commented on patch set 2 1 comment 07/05/11, 09:35
Looks good to me, but someone else must approve Apart from "nitpick" looks good to me. -
Stefan Neufeind commented on patch set 2 07/05/11, 09:35
I would prefer that you didn't submit this Hmm, we shouldn't just add deprecation-logs but also make the functions work again, shouldn't we? Here is the directory from 4.5.2 for comparison what was removed on the step towards 4.5.3: http://git.typo3.org/TYPO3v4/Core.git?a=tree;f=t3lib/formprotection;h=15cec881ac6b68bf0ea291d6143d69a7bc373301;hb=fab32e4a1f1d952afa70989d757211d8fee4909b -
Oliver Klee commented on patch set 2 07/05/11, 09:35
Looks good to me, but someone else must approve -
Philipp Gampe uploaded patch set 2 07/05/11, 09:35
class.t3lib_formprotection_backendformprotection.php:156Is this related? It sounds ridiculous, but I think a patch should only contain what is written in the commit message and not aditional cleanups. -
Philipp Gampe commented on patch set 2 07/05/11, 09:35
I just removed the .orig files. -
Philipp Gampe commented on patch set 2 07/05/11, 09:35
Either keep this and abandon 3016 or abandon this one. -
Philipp Gampe commented on patch set 2 1 comment 07/05/11, 09:35
Verified; Looks good to me, but someone else must approve Verified that it applies. As the new code does nothing, this can't be tested further. -
Mr. Jenkins commented on patch set 1 07/05/11, 09:35
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/175/ : SUCCESS -
Mr. Jenkins commented on patch set 2 07/05/11, 09:35
Build Successful http://ci.typo3.org/job/typo3-v4-core_4-5-gerrit/177/ : SUCCESS -
Dmitry Dulepov commented on patch set 2 V 0 07/05/11, 09:35
by team member -
Dmitry Dulepov merged patch set 2 07/05/11, 09:35