Review TYPO3_4-5 Merged

3017[BUGFIX] Re-Introduce removed API method and mark it deprecated

Helmut Hummel CR -1 V +2 Easy +31 −0 updated 06/03/13, 20:49

Commit message

After the refactoring of the form protection framework the API method
persitTokens() has been removed.

To not break existing extensions, re-introduce this method and
mark it as deprecated.

Review

  • Code review CR -1
    • Dmitry Dulepov +2
    • Stefan Neufeind -1
    • Oliver Klee +1
    • Philipp Gampe +1
  • Verified V +2
    • Dmitry Dulepov +2
    • Philipp Gampe +1

Issues 1

Files 3

Review log 12

  1. Dmitry Dulepov commented on patch set 2 07/05/11, 09:35

    Looks good to me, approved Logic is now different, so these functions should not work. We are adding them back as stubs only because we cannot remove functions so early.
  2. Stefan Neufeind commented on patch set 2 1 comment 07/05/11, 09:35

    Looks good to me, but someone else must approve Apart from "nitpick" looks good to me.
  3. Stefan Neufeind commented on patch set 2 07/05/11, 09:35

    I would prefer that you didn't submit this Hmm, we shouldn't just add deprecation-logs but also make the functions work again, shouldn't we? Here is the directory from 4.5.2 for comparison what was removed on the step towards 4.5.3: http://git.typo3.org/TYPO3v4/Core.git?a=tree;f=t3lib/formprotection;h=15cec881ac6b68bf0ea291d6143d69a7bc373301;hb=fab32e4a1f1d952afa70989d757211d8fee4909b
  4. Oliver Klee commented on patch set 2 07/05/11, 09:35

    Looks good to me, but someone else must approve
  5. Philipp Gampe uploaded patch set 2 07/05/11, 09:35

    class.t3lib_formprotection_backendformprotection.php:156

    Is this related? It sounds ridiculous, but I think a patch should only contain what is written in the commit message and not aditional cleanups.
  6. Philipp Gampe commented on patch set 2 07/05/11, 09:35

    I just removed the .orig files.
  7. Philipp Gampe commented on patch set 2 07/05/11, 09:35

    Either keep this and abandon 3016 or abandon this one.
  8. Philipp Gampe commented on patch set 2 1 comment 07/05/11, 09:35

    Verified; Looks good to me, but someone else must approve Verified that it applies. As the new code does nothing, this can't be tested further.
  9. Mr. Jenkins commented on patch set 1 07/05/11, 09:35

  10. Mr. Jenkins commented on patch set 2 07/05/11, 09:35

  11. Dmitry Dulepov commented on patch set 2 V 0 07/05/11, 09:35

    by team member
  12. Dmitry Dulepov merged patch set 2 07/05/11, 09:35