Review main Merged

30212[BUGFIX] Show content elements from hidden pages in preview

Jost Baron CR +2 V +2 Easy +2 −2 updated 06/05/14, 08:29

Commit message

Content elements from hidden pages are no longer shown in previews.

Fix this by checking with a strong comparison in enableFields() whether
the $show_hidden parameter is set to the default value.

Review

  • Code review CR +2
    • Marc Bastian Heinrichs +2
    • David Hoeckele +1
    • Mario Rimann +1
  • Verified V +2
    • Marc Bastian Heinrichs +2
    • anonymized-58955 +1

Issues 1

Files 1

Review log 15

  1. Mr. Jenkins commented on patch set 1 05/19/14, 12:44

  2. anonymized-58955 voted on patch set 1 V +1 05/19/14, 20:39

  3. Wouter Wolters wrote 05/19/14, 22:28

    Topic set to "regression".
  4. Markus Klein commented on patch set 1 V -1 05/21/14, 11:40

    This patch does not solve the problem for me.
  5. Markus Klein uploaded patch set 2 05/21/14, 11:45

  6. Markus Klein commented on patch set 2 05/21/14, 11:48

    PageRepository.php:962

    The reason why this failed was that TRUE == -1
  7. Mr. Jenkins commented on patch set 2 05/21/14, 11:59

  8. anonymized-58955 voted on patch set 2 V +1 05/23/14, 15:09

  9. Mario Rimann voted on patch set 2 CR +1 05/28/14, 05:50

  10. David Hoeckele voted on patch set 2 CR +1 05/28/14, 06:05

  11. Stefan Neufeind commented on patch set 2 05/28/14, 06:40

    PageRepository.php:962 Reply

    *argh* Thanks. From where is it called with TRUE? API says it's an integer, so calling it with a boolean is wrong (though more logical). Or should we also adjust the phpdoc to allow integer|boolean?
  12. Markus Klein commented on patch set 2 05/28/14, 09:15

    PageRepository.php:962 Reply

    Stefan, look at line 960. $GLOBALS['TSFE']->showHiddenPage and $GLOBALS['TSFE']->showHiddenRecords are both booleans.
  13. Marc Bastian Heinrichs voted on patch set 2 V +1 CR +1 06/05/14, 08:17

  14. Marc Bastian Heinrichs voted on patch set 2 V +2 CR +2 06/05/14, 08:29

  15. Marc Bastian Heinrichs merged patch set 3 06/05/14, 08:29