30212[BUGFIX] Show content elements from hidden pages in preview
Commit message
Review
-
Code review CR +2
- Marc Bastian Heinrichs +2
- David Hoeckele +1
- Mario Rimann +1
-
Verified V +2
- Marc Bastian Heinrichs +2
- anonymized-58955 +1
Issues 1
Files 1
Review log 15
-
Mr. Jenkins commented on patch set 1 05/19/14, 12:44
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16485/ : SUCCESS -
anonymized-58955 voted on patch set 1 V +1 05/19/14, 20:39
-
Wouter Wolters wrote 05/19/14, 22:28
Topic set to "regression". -
Markus Klein commented on patch set 1 V -1 05/21/14, 11:40
This patch does not solve the problem for me. -
Markus Klein uploaded patch set 2 05/21/14, 11:45
-
Markus Klein commented on patch set 2 05/21/14, 11:48
PageRepository.php:962The reason why this failed was that TRUE == -1 -
Mr. Jenkins commented on patch set 2 05/21/14, 11:59
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16494/ : SUCCESS -
anonymized-58955 voted on patch set 2 V +1 05/23/14, 15:09
-
Mario Rimann voted on patch set 2 CR +1 05/28/14, 05:50
-
David Hoeckele voted on patch set 2 CR +1 05/28/14, 06:05
-
Stefan Neufeind commented on patch set 2 05/28/14, 06:40
PageRepository.php:962Reply*argh* Thanks. From where is it called with TRUE? API says it's an integer, so calling it with a boolean is wrong (though more logical). Or should we also adjust the phpdoc to allow integer|boolean? -
Markus Klein commented on patch set 2 05/28/14, 09:15
PageRepository.php:962ReplyStefan, look at line 960. $GLOBALS['TSFE']->showHiddenPage and $GLOBALS['TSFE']->showHiddenRecords are both booleans. -
Marc Bastian Heinrichs voted on patch set 2 V +1 CR +1 06/05/14, 08:17
-
Marc Bastian Heinrichs voted on patch set 2 V +2 CR +2 06/05/14, 08:29
-
Marc Bastian Heinrichs merged patch set 3 06/05/14, 08:29