Review main Merged

30242[BUGFIX] Flexform element title is cropped to hardcoded length

Sebastian Michaelsen CR +2 V +2 Easy +1 −1 updated 05/29/14, 14:48

Commit message

The title of a flexform element is cropped to maximum length of 30
characters. Instead it should obey the maximum title length in the user
settings.

Review

  • Code review CR +2
    • Wouter Wolters +2
  • Verified V +2
    • Wouter Wolters +2

Issues 1

Files 1

Review log 7

  1. Georg Ringer voted on patch set 1 V +1 CR +1 05/21/14, 08:04

  2. Mr. Jenkins commented on patch set 1 05/21/14, 08:14

  3. Wouter Wolters commented on patch set 1 CR -1 05/29/14, 14:33

    patch will follow in a minute

    FormEngine.php:2973

    like in other places add a cast to int here.
  4. Wouter Wolters uploaded patch set 2 05/29/14, 14:33

  5. Wouter Wolters commented on patch set 2 V +2 CR +2 05/29/14, 14:34

    Only added the cast to int
  6. Wouter Wolters merged patch set 3 05/29/14, 14:34

  7. Mr. Jenkins commented on patch set 2 05/29/14, 14:48