30329[BUGFIX] Typos in t3skin css files
Commit message
Review
-
Code review CR +2
- Markus Klein +2
-
Verified V +2
- Markus Klein +2
Issues 1
Files 2
Review log 21
-
Mr. Jenkins commented on patch set 1 05/22/14, 14:26
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16521/ : SUCCESS -
Tymoteusz Motylewski voted on patch set 1 CR +1 05/22/14, 14:38
-
Wouter Wolters commented on patch set 1 V +1 CR +1 05/22/14, 20:33
Can be tested in Web -> Template tools for the stable styles Web -> List for the deprecated styles -
Stefan Neufeind commented on patch set 1 05/22/14, 23:43
The typos are obvious. But I'm unsure what we maybe break by fixing them. Are the settings actually *needed* somewhere? Or should we just remove those settings if nothing relies on them anyway (visually)? -
Krzysztof Adamczyk voted on patch set 1 CR +1 06/11/14, 08:06
-
Stefan Neufeind commented on patch set 1 06/11/14, 08:33
If nobody "missed" those properties, imho let's be safe and just remove those lines instead of risking changes in the frontend. -
Marcin Sągol voted on patch set 1 CR +1 06/11/14, 11:57
-
Tomita Militaru voted on patch set 1 V +1 CR +1 06/14/14, 09:23
-
Markus Klein updated the commit message in patch set 1 06/17/14, 18:05
-
Markus Klein uploaded patch set 3 06/17/14, 18:08
-
Markus Klein uploaded patch set 4 06/17/14, 18:20
-
Mr. Jenkins commented on patch set 2 06/17/14, 18:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16753/ : SUCCESS -
Mr. Jenkins commented on patch set 3 06/17/14, 19:02
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16754/ : SUCCESS -
Mr. Jenkins commented on patch set 4 06/17/14, 19:31
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16758/ : SUCCESS -
Marcin Sągol voted on patch set 4 CR +1 06/17/14, 19:35
-
Stefan Neufeind commented on patch set 4 V +1 CR +1 06/17/14, 21:31
Of course fine. Since it's misspelled removing it won't hurt :-) -
Markus Klein updated the commit message in patch set 4 06/17/14, 22:42
-
Markus Klein commented on patch set 5 V +2 CR +2 06/17/14, 22:42
Votes still valid, just adopted the commit message. -
Markus Klein merged patch set 6 06/17/14, 22:42
-
Markus Klein commented on patch set 6 06/17/14, 22:43
Cherry Picked This patchset was cherry picked to change: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36 -
Mr. Jenkins commented on patch set 5 06/17/14, 22:56
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16766/ : SUCCESS