Review main Merged

30329[BUGFIX] Typos in t3skin css files

Markus Klein CR +2 V +2 Easy +0 −2 updated 06/17/14, 22:56

Commit message

Remove the lines as they have not been valid, nobody will miss them.

Review

  • Code review CR +2
    • Markus Klein +2
  • Verified V +2
    • Markus Klein +2

Issues 1

Files 2

Review log 21

  1. Mr. Jenkins commented on patch set 1 05/22/14, 14:26

  2. Tymoteusz Motylewski voted on patch set 1 CR +1 05/22/14, 14:38

  3. Wouter Wolters commented on patch set 1 V +1 CR +1 05/22/14, 20:33

    Can be tested in Web -> Template tools for the stable styles Web -> List for the deprecated styles
  4. Stefan Neufeind commented on patch set 1 05/22/14, 23:43

    The typos are obvious. But I'm unsure what we maybe break by fixing them. Are the settings actually *needed* somewhere? Or should we just remove those settings if nothing relies on them anyway (visually)?
  5. Krzysztof Adamczyk voted on patch set 1 CR +1 06/11/14, 08:06

  6. Stefan Neufeind commented on patch set 1 06/11/14, 08:33

    If nobody "missed" those properties, imho let's be safe and just remove those lines instead of risking changes in the frontend.
  7. Marcin Sągol voted on patch set 1 CR +1 06/11/14, 11:57

  8. Tomita Militaru voted on patch set 1 V +1 CR +1 06/14/14, 09:23

  9. Markus Klein updated the commit message in patch set 1 06/17/14, 18:05

  10. Markus Klein uploaded patch set 3 06/17/14, 18:08

  11. Markus Klein uploaded patch set 4 06/17/14, 18:20

  12. Mr. Jenkins commented on patch set 2 06/17/14, 18:48

  13. Mr. Jenkins commented on patch set 3 06/17/14, 19:02

  14. Mr. Jenkins commented on patch set 4 06/17/14, 19:31

  15. Marcin Sągol voted on patch set 4 CR +1 06/17/14, 19:35

  16. Stefan Neufeind commented on patch set 4 V +1 CR +1 06/17/14, 21:31

    Of course fine. Since it's misspelled removing it won't hurt :-)
  17. Markus Klein updated the commit message in patch set 4 06/17/14, 22:42

  18. Markus Klein commented on patch set 5 V +2 CR +2 06/17/14, 22:42

    Votes still valid, just adopted the commit message.
  19. Markus Klein merged patch set 6 06/17/14, 22:42

  20. Markus Klein commented on patch set 6 06/17/14, 22:43

    Cherry Picked This patchset was cherry picked to change: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36
  21. Mr. Jenkins commented on patch set 5 06/17/14, 22:56