Review main Merged

30333[TASK] Category fields are not added to TCA interface section

Oliver Hader CR +2 V +2 Easy +27 −7 updated 03/15/15, 16:55

Commit message

$TCA[<table>]['interface']['showRecordFieldList'] contains a list
of fields that is used for visualizing
* accordant element details (record info)
* differences in the workspaces detail view

Fields that are treated as category should appear automatically.
If using CategoryRegistry::add() in extensions, the option
property "interface" can be used to disable this automated
handling in the interface section - in that case it needs
to be FALSE.

Review

  • Code review CR +2
    • Benni Mack +2
    • Markus Klein +1
  • Verified V +2
    • Benni Mack +2
    • Markus Klein +1

Issues 1

Files 1

Review log 13

  1. Markus Klein commented on patch set 1 CR -1 05/22/14, 15:08

    This needs a documentation ticket for the FALSE setting!
  2. Mr. Jenkins commented on patch set 1 05/22/14, 15:14

  3. Oliver Hader commented on patch set 1 05/27/14, 12:26

    Any other comments concerning the general behaviour?!
  4. Benni Mack commented on patch set 1 CR +1 06/12/14, 22:24

    I agree with Markus, but the rest seems fine. Maybe we can even check on === TRUE so one more step away from "1" and TRUE treated as synonyms.
  5. Benni Mack updated the commit message in patch set 2 11/23/14, 00:18

  6. Benni Mack voted on patch set 2 CR +1 11/23/14, 00:19

  7. Markus Klein commented on patch set 2 CR -1 11/23/14, 15:56

    CategoryRegistry.php:341

    new option needs to be documented here!
  8. Benni Mack uploaded patch set 3 01/29/15, 14:51

  9. Benni Mack voted on patch set 3 CR +1 01/29/15, 14:51

  10. Markus Klein uploaded patch set 4 03/14/15, 12:18

  11. Markus Klein voted on patch set 4 CR +1 V +1 03/14/15, 12:19

  12. Benni Mack voted on patch set 4 CR +2 V +2 03/15/15, 16:55

  13. Benni Mack merged patch set 4 03/15/15, 16:55