30376[BUGFIX] Fix redirect to install tool in new installations
Commit message
Review
-
Code review CR +2
- Wouter Wolters +2
- Stefan Neufeind +1
-
Verified V +2
- Wouter Wolters +2
- Stefan Neufeind +1
Issues 1
Files 1
Review log 27
Show 2 earlier messages
-
Stefan Neufeind commented on patch set 1 05/24/14, 19:56
Is there a special way for installation needed to trigger this issue? Today I just grabbed a 6.2.3 and did a clean install. I didn't stumble across an error (without this patch). -
Markus Klein commented on patch set 1 05/25/14, 20:09
We need to check if < 6.2 is affected too. -
Helmut Hummel voted on patch set 1 CR -1 05/26/14, 19:04
-
Helmut Hummel commented on patch set 1 05/26/14, 19:05
Bootstrap.php:174at this point TYPO3_REQUESTTYPE_INSTALL is not defined yet thus, TYPO3_REQUESTTYPE will contain the string "TYPO3_REQUESTTYPE_INSTALL" -
Helmut Hummel uploaded patch set 2 05/26/14, 19:09
-
Helmut Hummel voted on patch set 2 V +1 CR +1 05/26/14, 19:09
-
Mr. Jenkins commented on patch set 2 05/26/14, 19:23
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16530/ : SUCCESS -
Helmut Hummel commented on patch set 2 05/26/14, 19:34
@Stefan: did you access the install tool directly? or did you access the domain (fe or be) -
Stefan Neufeind commented on patch set 2 05/26/14, 19:38
@Helmut: Afaik I just accessed the index.php which informed me to create the first-install-file and forwarded me to the installer then. Will retest that again here ... -
Helmut Hummel updated the commit message in patch set 2 05/26/14, 19:38
-
Helmut Hummel commented on patch set 3 05/26/14, 19:39
I clarified the commit message -
Mr. Jenkins commented on patch set 3 05/26/14, 19:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16531/ : SUCCESS -
Anja Leichsenring voted on patch set 3 V +1 CR +1 05/26/14, 19:56
-
Stefan Neufeind commented on patch set 3 V +1 05/26/14, 19:59
I must have previously called it via /typo3/install/ manually - that already worked without the patch :-) -
Helmut Hummel updated the commit message in patch set 3 05/26/14, 20:00
-
Helmut Hummel commented on patch set 4 05/26/14, 20:01
sorry, can you re-apply the votes? This issue is valid vor 6.2, 6.1, 6.0 but not for 4.x as in 4.x the redirect is performed at a later stage where the configuration value is already present -
Anja Leichsenring voted on patch set 4 V +1 CR +1 05/26/14, 20:04
-
Mr. Jenkins commented on patch set 4 05/26/14, 20:15
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16534/ : SUCCESS -
Stefan Neufeind commented on patch set 4 V +1 CR +1 05/26/14, 20:36
reapplying votes -
Markus Klein commented on patch set 4 05/29/14, 13:34
Code does not exist in 6.0 -
Markus Klein updated the commit message in patch set 4 05/29/14, 13:34
-
Stefan Neufeind commented on patch set 5 V +1 CR +1 05/29/14, 13:35
reapplying votes -
Wouter Wolters voted on patch set 5 V +2 CR +2 05/29/14, 13:39
-
Wouter Wolters merged patch set 6 05/29/14, 13:39
-
Mr. Jenkins commented on patch set 5 05/29/14, 13:48
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16569/ : SUCCESS