Review main Merged

30376[BUGFIX] Fix redirect to install tool in new installations

Markus Klein CR +2 V +2 Easy +2 −0 updated 05/29/14, 13:48

Commit message

When setting up a new TYPO3 installation, TYPO3 should redirect
to the install tool, when accessing the frontend or backend.

This redirect fails since introduction of the trustedHostsPattern
since no configuration is available at this point, while the
request itself is a BE or FE request, which will be denied in this
case.
Solution is to set the REQUEST_TYPE to INSTALL before doing the redirect
to install tool so that creating the redirect is allowed.

Review

  • Code review CR +2
    • Wouter Wolters +2
    • Stefan Neufeind +1
  • Verified V +2
    • Wouter Wolters +2
    • Stefan Neufeind +1

Issues 1

Files 1

Review log 27

Show 2 earlier messages
  1. Mr. Jenkins commented on patch set 1 05/24/14, 18:59

  2. Anja Leichsenring commented on patch set 1 V +1 CR +1 05/24/14, 19:56

    tested on a nginx setup, with error occuring without the patch.
  1. Stefan Neufeind commented on patch set 1 05/24/14, 19:56

    Is there a special way for installation needed to trigger this issue? Today I just grabbed a 6.2.3 and did a clean install. I didn't stumble across an error (without this patch).
  2. Markus Klein commented on patch set 1 05/25/14, 20:09

    We need to check if < 6.2 is affected too.
  3. Helmut Hummel voted on patch set 1 CR -1 05/26/14, 19:04

  4. Helmut Hummel commented on patch set 1 05/26/14, 19:05

    Bootstrap.php:174

    at this point TYPO3_REQUESTTYPE_INSTALL is not defined yet thus, TYPO3_REQUESTTYPE will contain the string "TYPO3_REQUESTTYPE_INSTALL"
  5. Helmut Hummel uploaded patch set 2 05/26/14, 19:09

  6. Helmut Hummel voted on patch set 2 V +1 CR +1 05/26/14, 19:09

  7. Mr. Jenkins commented on patch set 2 05/26/14, 19:23

  8. Helmut Hummel commented on patch set 2 05/26/14, 19:34

    @Stefan: did you access the install tool directly? or did you access the domain (fe or be)
  9. Stefan Neufeind commented on patch set 2 05/26/14, 19:38

    @Helmut: Afaik I just accessed the index.php which informed me to create the first-install-file and forwarded me to the installer then. Will retest that again here ...
  10. Helmut Hummel updated the commit message in patch set 2 05/26/14, 19:38

  11. Helmut Hummel commented on patch set 3 05/26/14, 19:39

    I clarified the commit message
  12. Mr. Jenkins commented on patch set 3 05/26/14, 19:54

  13. Anja Leichsenring voted on patch set 3 V +1 CR +1 05/26/14, 19:56

  14. Stefan Neufeind commented on patch set 3 V +1 05/26/14, 19:59

    I must have previously called it via /typo3/install/ manually - that already worked without the patch :-)
  15. Helmut Hummel updated the commit message in patch set 3 05/26/14, 20:00

  16. Helmut Hummel commented on patch set 4 05/26/14, 20:01

    sorry, can you re-apply the votes? This issue is valid vor 6.2, 6.1, 6.0 but not for 4.x as in 4.x the redirect is performed at a later stage where the configuration value is already present
  17. Anja Leichsenring voted on patch set 4 V +1 CR +1 05/26/14, 20:04

  18. Mr. Jenkins commented on patch set 4 05/26/14, 20:15

  19. Stefan Neufeind commented on patch set 4 V +1 CR +1 05/26/14, 20:36

    reapplying votes
  20. Markus Klein commented on patch set 4 05/29/14, 13:34

    Code does not exist in 6.0
  21. Markus Klein updated the commit message in patch set 4 05/29/14, 13:34

  22. Stefan Neufeind commented on patch set 5 V +1 CR +1 05/29/14, 13:35

    reapplying votes
  23. Wouter Wolters voted on patch set 5 V +2 CR +2 05/29/14, 13:39

  24. Wouter Wolters merged patch set 6 05/29/14, 13:39

  25. Mr. Jenkins commented on patch set 5 05/29/14, 13:48