Review TYPO3_6-1 Merged

30385[BUGFIX] Fix double ? in eID url for encryption key

Markus Klein CR +2 V +2 Easy +1 −1 updated 06/03/14, 16:08

Commit message

The AJAX url for retrieving a new encryption key contains
two question marks. This causes the request to fail.

Fix this by removing the superflous ? from the parameters.

Review

  • Code review CR +2
    • Markus Klein +2
    • Alexander Opitz +1
    • Wouter Wolters +1
    • Michael Schams +1
    • Helmut Hummel +1
  • Verified V +2
    • Markus Klein +2
    • Michael Schams +1
    • Helmut Hummel +1

Issues 1

Files 1

Review log 11

  1. Michael Schams commented on patch set 1 V -1 05/26/14, 09:00

    Unfortunately, same error: 503 Service Unavailable.
  2. Markus Klein commented on patch set 1 05/26/14, 09:47

    A 503 is weird. I've to test this. But no time today
  3. Helmut Hummel commented on patch set 1 05/26/14, 14:31

    I guess TYPO3_REQUESTTYPE is already defined when we hit the eID script
  4. Markus Klein commented on patch set 1 05/26/14, 14:51

    @Helmut: I didn't debug it, but I searched through the code and if I didn't overlook it, it is not set.
  5. Markus Klein uploaded patch set 2 06/02/14, 14:05

  6. Alexander Opitz voted on patch set 2 CR +1 06/02/14, 15:21

  7. Michael Schams commented on patch set 2 V +1 CR +1 06/03/14, 11:23

    Successfully tested in 6.1.9.
  8. Wouter Wolters voted on patch set 2 CR +1 06/03/14, 11:24

  9. Helmut Hummel voted on patch set 2 V +1 CR +1 06/03/14, 14:44

  10. Markus Klein voted on patch set 2 V +2 CR +2 06/03/14, 16:08

  11. Markus Klein merged patch set 3 06/03/14, 16:08