30389[BUGFIX] New content elements are always stored on pid 0
Commit message
Review
-
Code review CR +2
- Markus Klein +2
- Alexander Opitz +1
- Fabien Udriot +1
-
Verified V +2
- Markus Klein +2
- Alexander Opitz +1
- Fabien Udriot +1
Issues 1
Files 1
Review log 12
-
Mr. Jenkins commented on patch set 1 05/25/14, 17:47
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16528/ : SUCCESS -
Markus Klein commented on patch set 1 CR +1 05/25/14, 17:48
What a no-brainer. Obviously nobody checked all usages of the member variable. I have to check all occurrences later -
Fabien Udriot voted on patch set 1 CR +1 05/25/14, 18:05
-
Markus Klein commented on patch set 1 05/25/14, 20:05
NewContentElementController.php:159In the original code colPos = 0 was a valid colPos. Now this is not the case. In order to be 100% backward compatible, I'd suggest to: a) change the (int) cast to a (string) cast in line 126 b) check here with canBeInterpretedAsInteger() c) do the (int) cast in line 166 then -
Nicole Hummel commented on patch set 1 05/25/14, 21:19
NewContentElementController.php:159ReplyAs this value may be used in any third party hook, I would like to close the XSS. Will push a new patch -
Nicole Hummel uploaded patch set 2 05/25/14, 21:22
-
Mr. Jenkins commented on patch set 2 05/25/14, 21:35
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16529/ : SUCCESS -
Markus Klein commented on patch set 2 V +1 CR +1 05/25/14, 22:02
Thx Nicole! -
Fabien Udriot voted on patch set 2 V +1 CR +1 05/26/14, 07:56
-
Alexander Opitz voted on patch set 2 V +1 CR +1 05/26/14, 09:29
-
Markus Klein voted on patch set 2 V +2 CR +2 05/26/14, 09:58
-
Markus Klein merged patch set 3 05/26/14, 09:58