Review main Merged

3039[CLEANUP] Remove code duplication in saltedpasswords

Andreas Wolf CR +2 V +2 Normal +18 −36 updated 06/03/13, 20:49

Commit message

There is some duplicate code in tx_saltedpasswords_sv1::authUser().
This patch removes the code, making it more readable.

Review

  • Code review CR +2
    • Susi Moog +2
    • Christian Kuhn +1
  • Verified V +2
    • Susi Moog +2
    • Christian Kuhn +1

Issues 1

Files 1

Review log 12

  1. Tolleiv Nietsch commented on patch set 1 08/22/11, 17:20

    Verified; Looks good to me, but someone else must approve
  2. Stefan Neufeind commented on patch set 1 08/22/11, 17:20

    Looks good to me, but someone else must approve looks like you're right. nice catch
  3. Xavier Perseguers commented on patch set 1 08/22/11, 17:20

    Looks good to me, but someone else must approve
  4. Xavier Perseguers commented on patch set 1 08/22/11, 17:20

    Looks good to me, approved
  5. Christian Kuhn commented on patch set 1 08/22/11, 17:20

    (1 inline comment)
    forge issue ID missing
  6. Christian Kuhn commented on patch set 2 08/22/11, 17:20

    Verified; Looks good to me, but someone else must approve
  7. Christian Kuhn uploaded patch set 2 08/22/11, 17:20

  8. Steffen Ritter commented on patch set 1 08/22/11, 17:20

    Looks good to me, approved
  9. Mr. Jenkins commented on patch set 1 08/22/11, 17:20

  10. Mr. Jenkins commented on patch set 2 08/22/11, 17:20

  11. Susi Moog commented on patch set 2 V 0 08/22/11, 17:20

    by team member; Looks good to me, approved
  12. Susi Moog merged patch set 2 08/22/11, 17:20