Review TYPO3_4-5 Merged

3041[CLEANUP] Remove code duplication in saltedpasswords

Andreas Wolf CR +2 V +2 Normal +19 −34 updated 06/03/13, 20:49

Commit message

There is some duplicate code in tx_saltedpasswords_sv1::authUser(). This
patch removes the code, making it more readable.

Review

  • Code review CR +2
    • Andreas Wolf +2
  • Verified V +2
    • Andreas Wolf +2

Issues 1

Files 1

Review log 18

  1. Stefan Neufeind commented on patch set 1 10/26/11, 14:10

    Looks good to me, but someone else must approve looks like you're right. nice catch
  2. Stefan Neufeind commented on patch set 1 10/26/11, 14:10

    Easy catch. Somebody, please.
  3. Marcus Schwemer commented on patch set 1 10/26/11, 14:10

    The code could be simplified further more. There are two if - statements with the same condition. The line of the second block "$OK = 0" can be moved to the first block. Kind regards, Marcus
  4. Marcus Schwemer commented on patch set 1 10/26/11, 14:10

    Looks good to me, but someone else must approve Pls forget my last comment ... I was mislead by the side by side diff. Sorry. Kind regards, Marcus
  5. Marcus Schwemer voted on patch set 1 V 0 10/26/11, 14:10

  6. Markus Klein commented on patch set 1 10/26/11, 14:10

    (1 inline comment) Marcus, you're right.

    class.tx_saltedpasswords_sv1.php:256 Reply

    It is! But it has been moved up here to avoid an additional if statement. See line 278 in master.

    class.tx_saltedpasswords_sv1.php:283

    @Marcus: You're right, this line can be moved up to line 255.
  7. Andreas Wolf uploaded patch set 3 10/26/11, 14:10

  8. Dmitry Dulepov commented on patch set 2 10/26/11, 14:10

    (1 inline comment) Please, check inline comments. This patch is not identical to the patch in master.
  9. Stefan Neufeind commented on patch set 2 10/26/11, 14:10

    (1 inline comment)
  10. Markus Klein commented on patch set 2 10/26/11, 14:10

    No need. Just submit Patch Set 1. Andreas seems not to be very active in the last times, so somebody else could probably hit the submit button.
  11. Markus Klein uploaded patch set 2 10/26/11, 14:10

  12. Markus Klein commented on patch set 2 10/26/11, 14:10

    Please go ahead and submit this one right away; it's already in master for a long time: https://review.typo3.org/3039
  13. Markus Klein commented on patch set 2 10/26/11, 14:10

    (1 inline comment)
  14. Mr. Jenkins commented on patch set 1 10/26/11, 14:10

  15. Mr. Jenkins commented on patch set 2 10/26/11, 14:10

  16. Mr. Jenkins commented on patch set 3 10/26/11, 14:10

  17. Andreas Wolf commented on patch set 3 V 0 10/26/11, 14:10

    by team member; Looks good to me, approved Merging patch 1 (re-uploaded) as this is the same as in 4.6/master. v2 ist slightly more elegant, but the additional change can easily be re-introduced.
  18. Andreas Wolf merged patch set 3 10/26/11, 14:10