30433[BUGFIX] Placeholder attribute without useOrOverridePlaceholder
Commit message
Review
-
Code review CR -1
- Stefan Neufeind +2
- Mathias Schreiber +1
- Frans Saris +1
- Ernesto Baschny +1
- Helmut Hummel -1
-
Verified V +2
- Stefan Neufeind +2
- Mathias Schreiber +1
- Frans Saris +1
Issues 1
Files 1
Review log 24
-
Alexander Stehlik updated the commit message in patch set 1 05/26/14, 19:47
-
Mr. Jenkins commented on patch set 1 05/26/14, 19:54
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16532/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/26/14, 20:09
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/16533/ : SUCCESS -
Alexander Stehlik uploaded patch set 3 11/16/14, 10:46
-
Alexander Stehlik commented on patch set 3 11/16/14, 10:46
Resolved merge conflict -
Frans Saris voted on patch set 3 CR +1 11/16/14, 21:12
-
Georg Ringer commented on patch set 3 11/18/14, 06:57
should that be documented? -
Alexander Stehlik commented on patch set 3 11/18/14, 07:16
Well, the current documentation of the placeholder setting does not say anything about the mode setting anyways: http://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Input/Index.html#placeholder -
Alexander Stehlik commented on patch set 3 11/18/14, 07:28
I'm wondering if we should make this a bugfix and backport it to 6.2? -
Frans Saris commented on patch set 3 11/18/14, 07:52
+1 for also fixing this in 6.2 -
Alexander Stehlik updated the commit message in patch set 4 11/18/14, 07:53
-
Frans Saris voted on patch set 4 CR +1 V +1 12/02/14, 09:08
-
Stefan Neufeind commented on patch set 4 CR +1 12/06/14, 09:51
Haven't yet tried it. But I follow your argumentation that if a placeholder is set it might be wise to use it (to whatever the mode is set).being -
Alexander Stehlik updated the commit message in patch set 5 12/06/14, 10:56
-
Stefan Neufeind voted on patch set 5 CR +1 12/06/14, 11:06
-
Frans Saris voted on patch set 5 CR +1 V +1 12/06/14, 11:17
-
Mathias Schreiber commented on patch set 5 CR -2 V +1 12/06/14, 11:59
Could you (or someone else) add a small snippet that describes the new behaviour? -
Alexander Stehlik commented on patch set 5 12/06/14, 12:01
@Mathias: Sure not problem. Should I add it in the commit message, a changelog file or the issue in forge? -
Helmut Hummel commented on patch set 5 CR -1 12/06/14, 12:11
this is a change in behaviorreally target 6.2? -
Mathias Schreiber commented on patch set 5 CR +1 12/06/14, 12:21
sorry, brainfart -
Alexander Stehlik commented on patch set 5 12/06/14, 12:21
Well, this patch is pending since 6 month :( But it's true, this is a change in behavior, but the TCA documentation does not say anything about useOrOverridePlaceholder being required for this to work: http://docs.typo3.org/typo3cms/TCAReference/Reference/Columns/Input/Index.html#placeholder So basically this puts the documented and more logical behavior in place. That is why I would vote for also adding it to 6.2. I also can't see that this would break things badly. If you are using placeholders at the moment you use them together with the mode setting because they are not working without it. My 2 cents :) -
Ernesto Baschny commented on patch set 5 CR +1 12/08/14, 17:55
As far as I can see, the feature "placeholder" was introduced in 4.7 and at that time we had no "mode". So to keep it backwards compatible in 6.2 we need to apply this bugfix, because it was mistakenly constrained during the FALization in 6.0 with "useOrOverridePlaceholder". Placeholder should work without this "mode" also. So +1 on backporting this change to 6.2. -
Stefan Neufeind voted on patch set 5 CR +2 V +2 12/09/14, 00:09
-
Stefan Neufeind merged patch set 5 12/09/14, 00:09