Review main Abandoned

30436[WIP][BUGFIX] Language overlay for type / subtype / displayCond

Alexander Stehlik CR 0 V 0 Hard +359 −28 updated 12/16/15, 18:36

Commit message

A language overlay is performed before the form engine processes
the values for type or subtype switching and for displayCond
evaluation.

Additionally a bug in the language overlay logic for the type
value is fixed.

WIP: finalize functional testing.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 11

Review log 12

  1. Mr. Jenkins commented on patch set 1 05/26/14, 20:23

  2. Mathias Schreiber wrote 12/17/14, 14:34

    Topic set to Formengine
  3. Benni Mack wrote 05/07/15, 17:31

    Topic changed from Formengine to FormEngine
  4. Alexander Opitz commented on patch set 1 06/18/15, 12:09

    What is the state of this issue?
  5. Alexander Stehlik uploaded patch set 2 06/30/15, 20:35

  6. Alexander Stehlik commented on patch set 2 06/30/15, 20:37

    I'm not too happy with the condition matcher needing access to a method in the container. Any suggestions?
  7. Christian Kuhn commented on patch set 2 CR -1 06/30/15, 22:03

    i'm unsure about the issue completely and would have to verify / check the details. from coding point, i'd suggest to move the method you made public to the utility class for now ... the data preparation and tca checks will be extracted from the container / element structure in one of my next steps anyway.
    this sentence is at least misleading: iirc, formEngine is always fed with the already overlayed record.

    AbstractContainer.php:165

    -1: no public method here in the container class structure, except the render() method.

    ElementConditionMatcher.php:225

    this must be solved differently somehow. public method in AbstractContainer is not acceptable.
  8. Alexander Stehlik uploaded patch set 3 07/01/15, 06:37

  9. Alexander Stehlik commented on patch set 3 07/01/15, 06:40

    Thank you for your feedback and your input :) I think the new solution is better. You can ping me on slack if you want to discuss your general concerns.
  10. Christian Kuhn commented on patch set 3 CR -2 07/28/15, 15:32

    blocked for now, i'm fiddling in a very related area at the moment.
  11. Alexander Stehlik commented on patch set 3 09/13/15, 21:16

    Christian, should I look into this?
  12. Christian Kuhn abandoned the change 12/16/15, 18:36

    I'm abandoning this patch now - it should be solved now with the data processing.