Review main Merged

30461[BUGFIX] Always add wrapping div if dividers2tabs is disabled

Frans Saris CR +2 V +2 Easy +1 −3 updated 05/30/14, 15:21

Commit message

TCEforms is not wrapped in a div when dividers2tabs is disabled 
and a inline-element form element is present. As a result there 
is no background image/color shown.

This changes removes the check as the wrap is also needed when
inline-elements are present.

Review

  • Code review CR +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Kay Strobach +1
  • Verified V +2
    • Frans Saris +2
    • Wouter Wolters +1
    • Kay Strobach +1

Issues 1

Files 1

Review log 7

  1. Mr. Jenkins commented on patch set 1 05/28/14, 08:18

  2. Frans Saris updated the commit message in patch set 1 05/28/14, 09:58

  3. Mr. Jenkins commented on patch set 2 05/28/14, 10:13

  4. Wouter Wolters voted on patch set 2 V +1 CR +1 05/29/14, 13:12

  5. Kay Strobach voted on patch set 2 V +1 CR +1 05/30/14, 11:54

  6. Frans Saris voted on patch set 2 V +2 CR +2 05/30/14, 15:20

  7. Frans Saris merged patch set 3 05/30/14, 15:21